Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The configuration of Extended Services is not working when a path is included in the URL. #2759

Open
phungvannarich-kepler-aavn opened this issue Nov 22, 2024 · 5 comments
Labels
lang:typescript Pull requests that update Javascript code

Comments

@phungvannarich-kepler-aavn

The error occurs when the port is missing, resulting in a redundant colon (':') in the URL:
image

The error occurs when the port is included twice in the URL, resulting in a duplicate entry:
image

The version I am currently using is:
image

Could someone assist me in resolving this issue?

@phungvannarich-kepler-aavn
Copy link
Author

I made some adjustments to my Nginx configuration (for workaround), but it still returns an error:
image

I saw this message:
image

The version I am currently using is: https://hub.docker.com/layers/apache/incubator-kie-sandbox-extended-services/main/images/sha256-42aaf500ed4c5396272f6de6f163ec74e54a028b5e4b439e37f2f858d33fa787?context=explore

@jomarko
Copy link
Contributor

jomarko commented Nov 25, 2024

@phungvannarich-kepler-aavn thank you for reporting this issue. I checked source code, and we didn't assume the case without the port, We will need to fix it.

@jomarko jomarko added the lang:typescript Pull requests that update Javascript code label Nov 25, 2024
@jomarko
Copy link
Contributor

jomarko commented Nov 25, 2024

@phungvannarich-kepler-aavn may I ask you to try as workaround, put the host value same as you did in screenshots, but add ending /, so for example in the fist screenshot put:

https://abc.com/xyz/

@phungvannarich-kepler-aavn
Copy link
Author

@jomarko Thanks for your response! The workaround worked perfectly. Will the fix be included in version 10.0.0?

jomarko added a commit to jomarko/kie-tools that referenced this issue Nov 28, 2024
@jomarko
Copy link
Contributor

jomarko commented Nov 28, 2024

Hi @phungvannarich-kepler-aavn @thiagoelg

It seems we have three issues with the same root cause:

I wanted to ask what is your idea about refactoring the settings modal to be single property Href / Url. From my point of view it would be more aligned with the environment property configuration KIE_SANDBOX_EXTENDED_SERVICES_URL

Here I share how it would look like and also attaching log from the browser log, where correct ping is executed (it is red because I didn't have extended services running on such address).

Href/URL single setting

Screenshot 2024-11-28 102735

Browser console log

Screenshot 2024-11-28 102753

With similar change, we should also think, if the advanced settings of the extended services wizard in the current form makes sense.

Advanced settings extended services wizard

Screenshot 2024-11-28 103023

the problem is all that part from screenshot does not take into an account a case, when the url has a form:
[host][port][pathname]: http://localhost:21345/my-extended-services/
it assumes only:
[host][port]: http://localhost:21345/

On my fork, I have a branch kie-tools-issues#2759 with the commit that brings similar changes. Let me know, what you think about similar approach.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lang:typescript Pull requests that update Javascript code
Projects
None yet
Development

No branches or pull requests

2 participants