Comment unfinished code

apache · Jan 30, 2024 · 7fc6592 · 7fc6592
1 parent 1df21d8
commit 7fc6592
Showing 1 changed file with 46 additions and 43 deletions.
diff --git a/packages/dmn-editor/src/diagram/Diagram.tsx b/packages/dmn-editor/src/diagram/Diagram.tsx
@@ -405,50 +405,53 @@ export const Diagram = React.forwardRef<DiagramRef, { container: React.RefObject
               },
             });
 
+            // TODO: Decide what to do with Decision Services and multiple DRDs.
+            //
             // When adding a Decision Service to a DRD, we need to bring all its encapsulated and output Decisions with it, already formatted with autolayout.
-            if (drgElement.__$$element === "decisionService") {
-              const defaultDecisionDimensions = DEFAULT_NODE_SIZES[NODE_TYPES.decision](state.diagram.snapGrid);
-
-              let i = 0;
-              for (const decision of [
-                ...(drgElement.outputDecision ?? []),
-                ...(drgElement.encapsulatedDecision ?? []),
-              ]) {
-                i++;
-
-                const decisionHref = parseXmlHref(decision["@_href"]);
-
-                const decisionQNamePrefix = decisionHref.namespace
-                  ? getXmlNamespaceDeclarationName({
-                      model: state.dmn.model.definitions,
-                      namespace: decisionHref.namespace,
-                    })
-                  : undefined;
-
-                // If there's a shape for this Decision in the DRD already, we don't need to add anything.
-                // If not, we add a new shape for it.
-                if (!state.computed(state).indexes().dmnShapesByHref.has(decision["@_href"])) {
-                  addShape({
-                    definitions: state.dmn.model.definitions,
-                    drdIndex: state.diagram.drdIndex,
-                    nodeType,
-                    shape: {
-                      "@_dmnElementRef": buildXmlQName({
-                        type: "xml-qname",
-                        localPart: decisionHref.id,
-                        prefix: decisionQNamePrefix,
-                      }),
-                      "dc:Bounds": {
-                        "@_x": dropPoint.x + 40 * i,
-                        "@_y": dropPoint.y + 40 * i,
-                        "@_width": defaultDecisionDimensions["@_width"],
-                        "@_height": defaultDecisionDimensions["@_height"],
-                      },
-                    },
-                  });
-                }
-              }
-            }
+            //
+            // if (drgElement.__$$element === "decisionService") {
+            //   const defaultDecisionDimensions = DEFAULT_NODE_SIZES[NODE_TYPES.decision](state.diagram.snapGrid);
+
+            //   let i = 0;
+            //   for (const decision of [
+            //     ...(drgElement.outputDecision ?? []),
+            //     ...(drgElement.encapsulatedDecision ?? []),
+            //   ]) {
+            //     i++;
+
+            //     const decisionHref = parseXmlHref(decision["@_href"]);
+
+            //     const decisionQNamePrefix = decisionHref.namespace
+            //       ? getXmlNamespaceDeclarationName({
+            //           model: state.dmn.model.definitions,
+            //           namespace: decisionHref.namespace,
+            //         })
+            //       : undefined;
+
+            //     // If there's a shape for this Decision in the DRD already, we don't need to add anything.
+            //     // If not, we add a new shape for it.
+            //     if (!state.computed(state).indexes().dmnShapesByHref.has(decision["@_href"])) {
+            //       addShape({
+            //         definitions: state.dmn.model.definitions,
+            //         drdIndex: state.diagram.drdIndex,
+            //         nodeType,
+            //         shape: {
+            //           "@_dmnElementRef": buildXmlQName({
+            //             type: "xml-qname",
+            //             localPart: decisionHref.id,
+            //             prefix: decisionQNamePrefix,
+            //           }),
+            //           "dc:Bounds": {
+            //             "@_x": dropPoint.x + 40 * i,
+            //             "@_y": dropPoint.y + 40 * i,
+            //             "@_width": defaultDecisionDimensions["@_width"],
+            //             "@_height": defaultDecisionDimensions["@_height"],
+            //           },
+            //         },
+            //       });
+            //     }
+            //   }
+            // }
           });
 
           console.debug(`DMN DIAGRAM: Adding DRG node`, JSON.stringify(drgElement));