Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make KieModuleMarshaller run time initialized #1594

Merged
merged 1 commit into from
Oct 2, 2021
Merged

Make KieModuleMarshaller run time initialized #1594

merged 1 commit into from
Oct 2, 2021

Conversation

galderz
Copy link
Contributor

@galderz galderz commented Oct 1, 2021

Closes quarkusio/quarkus#20491

A simple way to fix the issue is to make KieModuleMarshaller run-time initialized.

@Sanne mentioned here:

I had a quick look at java.awt.datatransfer.DataFlavor.. I could be wrong but it looks like a perfect candidate to be optimized via build time initialization.

Not sure exactly what he means, but at a first glance, everything awt related/dependant should really be runtime initialized to start with. Then, you can always optimize further things as needed/required.

@kie-ci
Copy link
Contributor

kie-ci commented Oct 1, 2021

Can one of the admins verify this patch?

28 similar comments
@kie-ci
Copy link
Contributor

kie-ci commented Oct 1, 2021

Can one of the admins verify this patch?

@kie-ci
Copy link
Contributor

kie-ci commented Oct 1, 2021

Can one of the admins verify this patch?

@kie-ci
Copy link
Contributor

kie-ci commented Oct 1, 2021

Can one of the admins verify this patch?

@kie-ci
Copy link
Contributor

kie-ci commented Oct 1, 2021

Can one of the admins verify this patch?

@kie-ci
Copy link
Contributor

kie-ci commented Oct 1, 2021

Can one of the admins verify this patch?

@kie-ci
Copy link
Contributor

kie-ci commented Oct 1, 2021

Can one of the admins verify this patch?

@kie-ci
Copy link
Contributor

kie-ci commented Oct 1, 2021

Can one of the admins verify this patch?

@kie-ci
Copy link
Contributor

kie-ci commented Oct 1, 2021

Can one of the admins verify this patch?

@kie-ci
Copy link
Contributor

kie-ci commented Oct 1, 2021

Can one of the admins verify this patch?

@kie-ci
Copy link
Contributor

kie-ci commented Oct 1, 2021

Can one of the admins verify this patch?

@kie-ci
Copy link
Contributor

kie-ci commented Oct 1, 2021

Can one of the admins verify this patch?

@kie-ci
Copy link
Contributor

kie-ci commented Oct 1, 2021

Can one of the admins verify this patch?

@kie-ci
Copy link
Contributor

kie-ci commented Oct 1, 2021

Can one of the admins verify this patch?

@kie-ci
Copy link
Contributor

kie-ci commented Oct 1, 2021

Can one of the admins verify this patch?

@kie-ci
Copy link
Contributor

kie-ci commented Oct 1, 2021

Can one of the admins verify this patch?

@kie-ci
Copy link
Contributor

kie-ci commented Oct 1, 2021

Can one of the admins verify this patch?

@kie-ci
Copy link
Contributor

kie-ci commented Oct 1, 2021

Can one of the admins verify this patch?

@kie-ci
Copy link
Contributor

kie-ci commented Oct 1, 2021

Can one of the admins verify this patch?

@kie-ci
Copy link
Contributor

kie-ci commented Oct 1, 2021

Can one of the admins verify this patch?

@kie-ci
Copy link
Contributor

kie-ci commented Oct 1, 2021

Can one of the admins verify this patch?

@kie-ci
Copy link
Contributor

kie-ci commented Oct 1, 2021

Can one of the admins verify this patch?

@kie-ci
Copy link
Contributor

kie-ci commented Oct 1, 2021

Can one of the admins verify this patch?

@kie-ci
Copy link
Contributor

kie-ci commented Oct 1, 2021

Can one of the admins verify this patch?

@kie-ci
Copy link
Contributor

kie-ci commented Oct 1, 2021

Can one of the admins verify this patch?

@kie-ci
Copy link
Contributor

kie-ci commented Oct 1, 2021

Can one of the admins verify this patch?

@kie-ci
Copy link
Contributor

kie-ci commented Oct 1, 2021

Can one of the admins verify this patch?

@kie-ci
Copy link
Contributor

kie-ci commented Oct 1, 2021

Can one of the admins verify this patch?

@kie-ci
Copy link
Contributor

kie-ci commented Oct 1, 2021

Can one of the admins verify this patch?

@kie-ci
Copy link
Contributor

kie-ci commented Oct 1, 2021

Can one of the admins verify this patch?

15 similar comments
@kie-ci
Copy link
Contributor

kie-ci commented Oct 1, 2021

Can one of the admins verify this patch?

@kie-ci
Copy link
Contributor

kie-ci commented Oct 1, 2021

Can one of the admins verify this patch?

@kie-ci
Copy link
Contributor

kie-ci commented Oct 1, 2021

Can one of the admins verify this patch?

@kie-ci
Copy link
Contributor

kie-ci commented Oct 1, 2021

Can one of the admins verify this patch?

@kie-ci
Copy link
Contributor

kie-ci commented Oct 1, 2021

Can one of the admins verify this patch?

@kie-ci
Copy link
Contributor

kie-ci commented Oct 1, 2021

Can one of the admins verify this patch?

@kie-ci
Copy link
Contributor

kie-ci commented Oct 1, 2021

Can one of the admins verify this patch?

@kie-ci
Copy link
Contributor

kie-ci commented Oct 1, 2021

Can one of the admins verify this patch?

@kie-ci
Copy link
Contributor

kie-ci commented Oct 1, 2021

Can one of the admins verify this patch?

@kie-ci
Copy link
Contributor

kie-ci commented Oct 1, 2021

Can one of the admins verify this patch?

@kie-ci
Copy link
Contributor

kie-ci commented Oct 1, 2021

Can one of the admins verify this patch?

@kie-ci
Copy link
Contributor

kie-ci commented Oct 1, 2021

Can one of the admins verify this patch?

@kie-ci
Copy link
Contributor

kie-ci commented Oct 1, 2021

Can one of the admins verify this patch?

@kie-ci
Copy link
Contributor

kie-ci commented Oct 1, 2021

Can one of the admins verify this patch?

@kie-ci
Copy link
Contributor

kie-ci commented Oct 1, 2021

Can one of the admins verify this patch?

This was referenced Oct 1, 2021
Open
Closed
@triceo
Copy link
Contributor

triceo commented Oct 2, 2021

ok to test

@triceo
Copy link
Contributor

triceo commented Oct 2, 2021

jenkins run native tests

triceo
triceo approved these changes Oct 2, 2021
View reviewed changes
Copy link
Contributor

@triceo triceo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good when green, @galderz.
If something fails, and it likely will, I'll look into it - most likely, it will be some flaky test in one of the downstream repos.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 2, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@kie-ci
Copy link
Contributor

kie-ci commented Oct 2, 2021

The (build) kogito-apps check has failed. Please check the logs.

@kie-ci
Copy link
Contributor

kie-ci commented Oct 2, 2021

The (native) kogito-examples check has failed. Please check the logs.

@kie-ci
Copy link
Contributor

kie-ci commented Oct 2, 2021

The (native) kogito-apps check has failed. Please check the logs.

@triceo triceo merged commit abfdc79 into apache:main Oct 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@triceo triceo triceo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

OptaPlanner AWT DataFlavor build time init error
3 participants
@galderz @kie-ci @triceo