DROOLS-3834: Process generation in jBPM Mojo should not cause DRL compilation #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
looks nice and simple to me, assuming it all works for Jbpm examples I'd say merge it as soon as build is finished. |
|
does it build the examples as well? |
|
nope, only runtimes are currently covered |
mswiderski
approved these changes
Apr 3, 2019
baldimir
added a commit
to baldimir/kogito-runtimes
that referenced
this pull request
Sep 20, 2019
baldimir
added a commit
to baldimir/kogito-runtimes
that referenced
this pull request
Sep 23, 2019
mariofusco
pushed a commit
that referenced
this pull request
Sep 23, 2019
* KOGITO-113 Fix Major SonarCloud reported problems, part 1 * KOGITO-113 Fix Major SonarCloud reported problems, part 1.5 * KOGITO-113 Fix major issues reported by SonarCloud part #2 * KOGITO-113 Formatting fix * KOGITO-113 Fix traits * KOGITO-113 Fix major issues reported by SonarCloud part #3 * KOGITO-113 Fix major issues reported by SonarCloud part #4 * KOGITO-113 Fix major issues reported by SonarCloud part #5 * KOGITO-113 Fix major issues reported by SonarCloud part #6 * KOGITO-113 Fix major issues reported by SonarCloud part #7 * KOGITO-113 Revert change from SonarCloud fixes
lucamolteni
pushed a commit
to lucamolteni/kogito-runtimes
that referenced
this pull request
Jul 21, 2020
Revert to correct package for KogitoJunitActivator.java
rgdoliveira
added a commit
to rgdoliveira/kogito-runtimes
that referenced
this pull request
Nov 6, 2023
[1.44.2.x-prod] Bump Quarkus version to 2.13.8.Final
rgdoliveira
added a commit
to rgdoliveira/kogito-runtimes
that referenced
this pull request
Jan 25, 2024
… productized build (apache#7)
yesamer
pushed a commit
to yesamer/kogito-runtimes
that referenced
this pull request
Apr 22, 2024
… productized build (apache#7)
pefernan
added a commit
to pefernan/kogito-runtimes
that referenced
this pull request
Nov 26, 2024
…-url and user info. (apache#7) Co-authored-by: Pere Fernández <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously: the KieBuilderImplWhatever infrastracture is slow to boot (lots of classes, lots of dynamic loading, assemblers, kie.confs etc etc etc) and also hard do customize. In this case we want to just run only the BPMN process builder, but our infrastructure requires DRL files to be processed as well. This is useless work (there's a different MOJO for DRLs) and it's also the root cause of some weird behaviors (DRL evaluation might error out even though the file is correct only because the KieBuilder is misconfigured).
In short: instead of using
kieBuilder, I am bypassing the building API completely and just using XmlProcessReader because all of the KieBuild* infrastructure is already provided by Maven. So, bye-bye assemblers, KieServices and all their friends 👋👋👋I see no downsides in this for now, and we can enhance as we go.
Build has become much shorter, and it's easier to follow.