Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[incubator-kie-issues-1682] Test cases in kogito repos GHA fail with … #3812

Merged
merged 3 commits into from
Dec 12, 2024
Merged

[incubator-kie-issues-1682] Test cases in kogito repos GHA fail with … #3812

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
907dd10
[incubator-kie-issues-1682] Test cases in kogito repos GHA fail with …
tkobayas Dec 11, 2024
996af44
Fix advertise-kafka-addr in script command
gmunozfe Dec 12, 2024
2818109
Merge pull request #2 from gmunozfe/incubator-kie-issues-1682-redpanda
tkobayas Dec 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion kogito-build/kogito-build-no-bom-parent/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@
<!-- container images for testing -->
<container.image.infinispan>infinispan/server:${version.org.infinispan}</container.image.infinispan>
<container.image.keycloak>quay.io/keycloak/keycloak:${version.org.keycloak}</container.image.keycloak>
<container.image.kafka>vectorized/redpanda:v21.11.8</container.image.kafka>
<container.image.kafka>redpandadata/redpanda:v24.3.1</container.image.kafka>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Chose the latest version in https://hub.docker.com/r/redpandadata/redpanda/tags

v21.11.8 doesn't exist in redpandadata/redpanda.

<container.image.wurstmeister.kafka>wurstmeister/kafka:${version.wurstmeister.kafka}</container.image.wurstmeister.kafka>
<container.image.mongodb>library/mongo:${version.org.mongo-image}</container.image.mongodb>
<container.image.redis>redislabs/redisearch:${version.org.redis}</container.image.redis>
Expand Down
7 changes: 1 addition & 6 deletions kogito-test-utils/src/main/java/org/kie/kogito/testcontainers/KogitoKafkaContainer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,14 +53,13 @@ public KogitoKafkaContainer() {
@Override
protected void containerIsStarting(InspectContainerResponse containerInfo, boolean reused) {
super.containerIsStarting(containerInfo, reused);
String brokerAdvertisedListener = brokerAdvertisedListener(containerInfo);

// Start and configure the advertised address
String command = "#!/bin/bash\n";
command += "/usr/bin/rpk redpanda start --check=false --node-id 0 --smp 1 ";
command += "--memory 1G --overprovisioned --reserve-memory 0M ";
command += "--kafka-addr PLAINTEXT://0.0.0.0:29092,OUTSIDE://0.0.0.0:9092 ";
command += format("--advertise-kafka-addr %s ", String.join(",", getBootstrapServers(), brokerAdvertisedListener));
command += "--advertise-kafka-addr PLAINTEXT://kafka:29092,OUTSIDE://" + getHost() + ":" + getMappedPort(KAFKA_PORT) + " ";
command += "--set redpanda.enable_idempotence=true ";
command += "--set redpanda.enable_transactions=true ";

Expand All @@ -73,10 +72,6 @@ public void start() {
LOGGER.info("Kafka servers: {}", getBootstrapServers());
}

protected String brokerAdvertisedListener(InspectContainerResponse containerInfo) {
return String.format("PLAINTEXT://%s:29092", containerInfo.getConfig().getHostName());
}

public String getBootstrapServers() {
return format("OUTSIDE://%s:%d", getHost(), getMappedPort(KAFKA_PORT));
}
Expand Down
Loading