Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[incubator-kie-drools-6160] Clean up leftover of .rf support #3811

Merged
merged 1 commit into from
Dec 11, 2024

Conversation

tkobayas
Copy link
Contributor

@tkobayas tkobayas commented Dec 6, 2024

This PR is a part of apache/incubator-kie-drools#6160

depends on apache/incubator-kie-drools#6189

Removing DRF (.rf rulefow file) support. Actually, it has not been supported in kogito.

Please make sure that your PR meets the following requirements:

  • You have read the contributors guide
  • Your code is properly formatted according to this configuration
  • Pull Request title is properly formatted: Issue-XYZ Subject
  • Pull Request title contains the target branch if not targeting main: [0.9.x] Issue-XYZ Subject
  • Pull Request contains link to the JIRA issue
  • Pull Request contains link to any dependent or related Pull Request
  • Pull Request contains description of the issue
  • Pull Request does not include fixes for issues other than the main ticket
How to replicate CI configuration locally?

Build Chain tool does "simple" maven build(s), the builds are just Maven commands, but because the repositories relates and depends on each other and any change in API or class method could affect several of those repositories there is a need to use build-chain tool to handle cross repository builds and be sure that we always use latest version of the code for each repository.

build-chain tool is a build tool which can be used on command line locally or in Github Actions workflow(s), in case you need to change multiple repositories and send multiple dependent pull requests related with a change you can easily reproduce the same build by executing it on Github hosted environment or locally in your development environment. See local execution details to get more information about it.

@tkobayas tkobayas changed the title [incubator-kie-drools-6160] Clean up leftover of .rf support [DO-NOT-MERGE] [incubator-kie-drools-6160] Clean up leftover of .rf support Dec 6, 2024
@tkobayas tkobayas marked this pull request as ready for review December 10, 2024 08:10
@tkobayas tkobayas changed the title [DO-NOT-MERGE] [incubator-kie-drools-6160] Clean up leftover of .rf support [incubator-kie-drools-6160] Clean up leftover of .rf support Dec 10, 2024
@kie-ci3
Copy link
Contributor

kie-ci3 commented Dec 10, 2024

PR job #3 was: UNSTABLE
Possible explanation: This should be test failures

Reproducer

build-chain build full_downstream -f 'https://raw.githubusercontent.com/${AUTHOR:apache}/incubator-kie-kogito-pipelines/${BRANCH:main}/.ci/buildchain-config-pr-cdb.yaml' -o 'bc' -p apache/incubator-kie-kogito-runtimes -u #3811 --skipParallelCheckout

NOTE: To install the build-chain tool, please refer to https://github.com/kiegroup/github-action-build-chain#local-execution

Please look here: https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-3811/3/display/redirect

Test results:

  • PASSED: 3362
  • FAILED: 10

Those are the test failures:

org.kie.kogito.persistence.kafka.KafkaProcessInstancesIT.testBasicFlow Can't get Docker image: RemoteDockerImage(imageName=vectorized/redpanda:v21.11.8, imagePullPolicy=DefaultPullPolicy(), imageNameSubstitutor=Chained substitutor of 'DefaultImageNameSubstitutor (composite of 'ConfigurationFileImageNameSubstitutor' and 'PrefixingImageNameSubstitutor')' and then 'Kogito Image Name Substitutor')
org.kie.kogito.persistence.kafka.KafkaProcessInstancesIT.testValuesReadMode Can't get Docker image: RemoteDockerImage(imageName=vectorized/redpanda:v21.11.8, imagePullPolicy=DefaultPullPolicy(), imageNameSubstitutor=Chained substitutor of 'DefaultImageNameSubstitutor (composite of 'ConfigurationFileImageNameSubstitutor' and 'PrefixingImageNameSubstitutor')' and then 'Kogito Image Name Substitutor')
org.kie.kogito.persistence.kafka.KafkaProcessInstancesIT.testFindByIdReadMode Can't get Docker image: RemoteDockerImage(imageName=vectorized/redpanda:v21.11.8, imagePullPolicy=DefaultPullPolicy(), imageNameSubstitutor=Chained substitutor of 'DefaultImageNameSubstitutor (composite of 'ConfigurationFileImageNameSubstitutor' and 'PrefixingImageNameSubstitutor')' and then 'Kogito Image Name Substitutor')
org.kie.kogito.quarkus.workflows.AsyncAPIIT.testConsumer java.util.concurrent.CompletionException: java.lang.RuntimeException: Unable to start Quarkus test resource class org.kie.kogito.testcontainers.quarkus.KafkaQuarkusTestResource
org.kie.kogito.quarkus.workflows.EmitEnumRPCGreetIT.testStateIsUnknown java.util.concurrent.CompletionException: java.lang.RuntimeException: Unable to start Quarkus test resource class org.kie.kogito.testcontainers.quarkus.KafkaQuarkusTestResource
org.kie.kogito.it.KafkaPersistenceIT.testPersistence java.util.concurrent.CompletionException: java.lang.RuntimeException: Unable to start Quarkus test resource class org.kie.kogito.testcontainers.quarkus.KafkaQuarkusTestResource
org.kie.kogito.integrationtests.quarkus.AdHocFragmentsIT.testUserTaskProcess java.util.concurrent.CompletionException: java.lang.RuntimeException: Unable to start Quarkus test resource class org.kie.kogito.testcontainers.quarkus.KafkaQuarkusTestResource
org.kie.kogito.integrationtests.springboot.ProcessEventIT.testSaveTask Failed to load ApplicationContext for [WebMergedContextConfiguration@33a8c9c9 testClass = org.kie.kogito.integrationtests.springboot.ProcessEventIT, locations = [], classes = [org.kie.kogito.integrationtests.springboot.KogitoSpringbootApplication], contextInitializerClasses = [org.kie.kogito.testcontainers.springboot.KafkaSpringBootTestResource], activeProfiles = [], propertySourceDescriptors = [], propertySourceProperties = ["org.springframework.boot.test.context.SpringBootTestContextBootstrapper=true", "server.port=0"], contextCustomizers = [org.springframework.boot.test.context.filter.ExcludeFilterContextCustomizer@75c56eb9, org.springframework.boot.test.json.DuplicateJsonObjectContextCustomizerFactory$DuplicateJsonObjectContextCustomizer@5e17553a, org.springframework.boot.test.mock.mockito.MockitoContextCustomizer@0, org.springframework.boot.test.web.client.TestRestTemplateContextCustomizer@6dd7b5a3, org.springframework.boot.test.autoconfigure.actuate.observability.ObservabilityContextCustomizerFactory$DisableObservabilityContextCustomizer@1f, org.springframework.boot.test.autoconfigure.properties.PropertyMappingContextCustomizer@0, org.springframework.boot.test.autoconfigure.web.servlet.WebDriverContextCustomizer@895e367, org.springframework.boot.test.context.SpringBootTestAnnotation@b16e4dcc], resourceBasePath = "src/main/webapp", contextLoader = org.springframework.boot.test.context.SpringBootContextLoader, parent = null]
org.kie.kogito.integrationtests.springboot.PingPongMessageTest.verifyTopicsInformation Failed to load ApplicationContext for [WebMergedContextConfiguration@5abf9a76 testClass = org.kie.kogito.integrationtests.springboot.PingPongMessageTest, locations = [], classes = [org.kie.kogito.integrationtests.springboot.KogitoSpringbootApplication], contextInitializerClasses = [org.kie.kogito.testcontainers.springboot.KafkaSpringBootTestResource], activeProfiles = [], propertySourceDescriptors = [], propertySourceProperties = ["org.springframework.boot.test.context.SpringBootTestContextBootstrapper=true", "server.port=0"], contextCustomizers = [org.springframework.boot.test.context.filter.ExcludeFilterContextCustomizer@2caf6912, org.springframework.boot.test.json.DuplicateJsonObjectContextCustomizerFactory$DuplicateJsonObjectContextCustomizer@aed0151, org.springframework.boot.test.mock.mockito.MockitoContextCustomizer@0, org.springframework.boot.test.web.client.TestRestTemplateContextCustomizer@4e558728, org.springframework.boot.test.autoconfigure.actuate.observability.ObservabilityContextCustomizerFactory$DisableObservabilityContextCustomizer@1f, org.springframework.boot.test.autoconfigure.properties.PropertyMappingContextCustomizer@0, org.springframework.boot.test.autoconfigure.web.servlet.WebDriverContextCustomizer@3605c4d3, org.springframework.boot.test.context.SpringBootTestAnnotation@c2e41d2f], resourceBasePath = "src/main/webapp", contextLoader = org.springframework.boot.test.context.SpringBootContextLoader, parent = null]
org.kie.kogito.integrationtests.springboot.PingPongMessageTest.testPingPongBetweenProcessInstances ApplicationContext failure threshold (1) exceeded: skipping repeated attempt to load context for [WebMergedContextConfiguration@5abf9a76 testClass = org.kie.kogito.integrationtests.springboot.PingPongMessageTest, locations = [], classes = [org.kie.kogito.integrationtests.springboot.KogitoSpringbootApplication], contextInitializerClasses = [org.kie.kogito.testcontainers.springboot.KafkaSpringBootTestResource], activeProfiles = [], propertySourceDescriptors = [], propertySourceProperties = ["org.springframework.boot.test.context.SpringBootTestContextBootstrapper=true", "server.port=0"], contextCustomizers = [org.springframework.boot.test.context.filter.ExcludeFilterContextCustomizer@2caf6912, org.springframework.boot.test.json.DuplicateJsonObjectContextCustomizerFactory$DuplicateJsonObjectContextCustomizer@aed0151, org.springframework.boot.test.mock.mockito.MockitoContextCustomizer@0, org.springframework.boot.test.web.client.TestRestTemplateContextCustomizer@4e558728, org.springframework.boot.test.autoconfigure.actuate.observability.ObservabilityContextCustomizerFactory$DisableObservabilityContextCustomizer@1f, org.springframework.boot.test.autoconfigure.properties.PropertyMappingContextCustomizer@0, org.springframework.boot.test.autoconfigure.web.servlet.WebDriverContextCustomizer@3605c4d3, org.springframework.boot.test.context.SpringBootTestAnnotation@c2e41d2f], resourceBasePath = "src/main/webapp", contextLoader = org.springframework.boot.test.context.SpringBootContextLoader, parent = null]

@tkobayas tkobayas requested a review from mariofusco December 11, 2024 07:38
@tkobayas tkobayas merged commit 52fd03b into apache:main Dec 11, 2024
9 of 15 checks passed
rgdoliveira pushed a commit to rgdoliveira/kogito-runtimes that referenced this pull request Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants