-
Notifications
You must be signed in to change notification settings - Fork 219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[incubator-kie-issues#1575] Upgrade quarkus to 3.15 #3750
Open
RishiRajAnand
wants to merge
31
commits into
apache:main
Choose a base branch
from
RishiRajAnand:upgrade-quarkus-3.15
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
31 commits
Select commit
Hold shift + click to select a range
99674ba
Upgrade quarkus to 3.15
RishiRajAnand 75c0c41
Fix errors due to flyway 10 upgrade
RishiRajAnand 1a773b8
Fix infinispan protostream errors due to upgrade
RishiRajAnand fed06df
Align kubernetes-client version to quarkus supported version 6.13.3
RishiRajAnand 25e5c22
Upgrade quarkus to 3.15.2
RishiRajAnand c46863c
Updating jandex and quarkus camel
RishiRajAnand 7b534b5
Upgrading h2 version to 2.3.232 and aligning other library versions
RishiRajAnand 0d5f39f
replacing quarkus-smallrye-reactive-messaging-kafka with new name
RishiRajAnand 41ed0fa
fix DevMojoIT test failures
RishiRajAnand 0102846
Upgrade openapi-generator to 2.6.0 lts
RishiRajAnand 040296c
Upgrading h2 version to 2.3.232 and aligning other library versions
RishiRajAnand 14e3e66
- Upgrade `quarkus-openapi-generator` to `2.7.0-lts`
pefernan 2fb2b8a
Reverting postgresql fly way dependency
RishiRajAnand 907e588
Fixing sanity verification tests
RishiRajAnand 5fb9960
Reverting flyway postgres changes
RishiRajAnand 16424d4
- Fix formatting
pefernan a8b3d08
- Fix typo
pefernan 9803e43
- Fix tests
pefernan e36f972
Disable analytics
RishiRajAnand d0e3c23
Disable analytics
RishiRajAnand 7edec05
Fixing Dev Mojo IT
RishiRajAnand 59126dd
Minor refactoring as per migration guide 3.9
RishiRajAnand 30564c1
Update quarkus version to 3.15.3 LTS
RishiRajAnand 216eb79
Update vertx and grpc
RishiRajAnand aeeac5b
Align maven compiler version with quarkus
RishiRajAnand 8938adc
- Upgrade `io.quarkiverse.embedded.postgresql:quarkus-embedded-postgr…
pefernan 676aa02
- Upgrade `io.quarkiverse.openapi.generator:quarkus-openapi-generator…
pefernan a7a3fd0
- fix `integration-tests-quarkus-openapi-client`
pefernan ef13c20
Minor renames as per migration guide 3.9
RishiRajAnand 8b31bb0
Updating quarkus.package.type as per migration guide
RishiRajAnand 9ea3944
- Remove unnecessary `xstream` dependency
pefernan File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -51,6 +51,11 @@ | |
<type>pom</type> | ||
<scope>test</scope> | ||
</dependency> | ||
<dependency> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @fjtirado same here, adding it for testing purposes. |
||
<groupId>org.flywaydb</groupId> | ||
<artifactId>flyway-database-postgresql</artifactId> | ||
<scope>test</scope> | ||
</dependency> | ||
<dependency> | ||
<groupId>org.postgresql</groupId> | ||
<artifactId>postgresql</artifactId> | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmmm, here we are adding a flyway dependency intended for a particular db in a common addon. I do not think thats the way to go. Im afraid this has to be moved somewhere else
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fjtirado the problem here is that flyway has changed a bit between v9 and v10. In v9 the core module was including the support for almost all db like pgsql, h2, mysql... but other propietary db'a (like sql server) had its own
flyway-database-<vendor>
maven module that should be manually included in the application pom.xml. In v10 they trimmed a bit more the flyway-core module, leaving only H2 and SQL Lite. So to allow Flyway work with any specific DB that isn't H2/SQL Lite it will be required adding the specific supporting database module.In this module we had to include the
flyway-database-postgresql
to allow the tests pass.