Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[incubator-kie-issues-1553] Centralize shared vars for different Github actions workflows #3742

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

gmunozfe
Copy link
Contributor

@gmunozfe gmunozfe commented Oct 21, 2024

Many thanks for submitting your Pull Request ❤️!

Closes/Fixes/Resolves #1553

Build with apache/incubator-kie-kogito-apps#2123

How to replicate CI configuration locally?

Build Chain tool does "simple" maven build(s), the builds are just Maven commands, but because the repositories relates and depends on each other and any change in API or class method could affect several of those repositories there is a need to use build-chain tool to handle cross repository builds and be sure that we always use latest version of the code for each repository.

build-chain tool is a build tool which can be used on command line locally or in Github Actions workflow(s), in case you need to change multiple repositories and send multiple dependent pull requests related with a change you can easily reproduce the same build by executing it on Github hosted environment or locally in your development environment. See local execution details to get more information about it.

@gmunozfe gmunozfe requested a review from fjtirado October 21, 2024 12:14
@pibizza
Copy link
Contributor

pibizza commented Oct 21, 2024

Hi Gonzalo, this is very interesting. I would generalize this also to other kie repositories, like drools. WDYT?

@gmunozfe gmunozfe requested a review from baldimir October 21, 2024 12:32
@gmunozfe
Copy link
Contributor Author

Hi Gonzalo, this is very interesting. I would generalize this also to other kie repositories, like drools. WDYT?

Sure, the idea is to do it in other repos as well: apps, etc.

@kie-ci3
Copy link
Contributor

kie-ci3 commented Oct 21, 2024

PR job #1 was: UNSTABLE
Possible explanation: This should be test failures

Reproducer

build-chain build full_downstream -f 'https://raw.githubusercontent.com/${AUTHOR:apache}/incubator-kie-kogito-pipelines/${BRANCH:main}/.ci/buildchain-config-pr-cdb.yaml' -o 'bc' -p apache/incubator-kie-kogito-runtimes -u #3742 --skipParallelCheckout

NOTE: To install the build-chain tool, please refer to https://github.com/kiegroup/github-action-build-chain#local-execution

Please look here: https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-3742/1/display/redirect

Test results:

  • PASSED: 2933
  • FAILED: 3

Those are the test failures:

org.jbpm.bpmn2.IntermediateEventTest.testTimerBoundaryEventInterrupting
expected: 2
but was: 1
org.jbpm.bpmn2.IntermediateEventTest.testIntermediateCatchEventTimerDuration
expected: 2
but was: 1
org.jbpm.bpmn2.IntermediateEventTest.testEventBasedSplit2
expected: 2
but was: 1

@gmunozfe gmunozfe force-pushed the Fixes_1553 branch 12 times, most recently from c01b2b5 to b0faaf2 Compare October 21, 2024 18:48
@gmunozfe gmunozfe changed the title Centralize shared vars for different Github actions workflows [incubator-kie-issues-1553] Centralize shared vars for different Github actions workflows Oct 22, 2024
@baldimir
Copy link
Contributor

baldimir commented Oct 22, 2024

I personally would much more prefer, to use the CI image that we have in Jenkins PR checks, also for GitHub actions. That would mean all the configuration would be centralized in the single CI image (for both Jenkins and GitHub Actions PR checks), instead of having shared_vars configuration in each repository. In case of a change, only the CI image would need to be updated, instead of updating files across multiple repositories.

Here is the CI image for reference:
Dockerfile: https://github.com/apache/incubator-kie-kogito-pipelines/blob/main/apache-nodes/Dockerfile.kogito-ci-build
Image: docker.io/apache/incubator-kie-kogito-ci-build:main-latest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Centralize shared vars for different Github actions workflows
5 participants