-
Notifications
You must be signed in to change notification settings - Fork 210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kie-issues#1613: Add CI :: License headers
GitHub Actions workflow
#3714
Open
jomarko
wants to merge
25
commits into
apache:main
Choose a base branch
from
jomarko:runtimes-license
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+639
−59
Open
Changes from 17 commits
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
00cfcc5
Add license header
jomarko eb60175
Revert "Add license header"
jomarko 5727aeb
Add license header
jomarko 2dd019c
revert beans.xml
jomarko 012973d
Merge branch 'main' into runtimes-license
jomarko a83d727
.rat-excludes and rat check action
jomarko 1361fed
remove checkstyle.header.template
jomarko 8ac99a2
OMG BPMN SPEC files license
jomarko ab721ea
.rat-excludes fix format - escaping
jomarko 360aa1e
.rat-excludes
jomarko bcd348d
storage-jpa license
jomarko 906228d
apache rat 17
jomarko f4d6031
fix exit logic
jomarko ee0d2e9
print rat check output
jomarko 3a59917
align with other PRs of kie-issues#1613
jomarko 46927e6
license text placeholder
jomarko 3e4e2f8
LICENSE SPEC
jomarko 28d419e
Revert "LICENSE SPEC"
jomarko 0a6bcaa
List explicitely all files in the .rat-excludes
jomarko 8e0651d
Use apache-rat v0.16.1
jomarko 62e9a72
Everthing -> Everything
jomarko b78016f
BPMN LICENSE text
jomarko 4780813
Merge branch 'main' into runtimes-license
jomarko a217085
CI :: License headers
jomarko d0e2f80
kogito-codegen-modules/kogito-codegen-processes-integration-tests/src…
jomarko File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,42 @@ | ||
# | ||
# Licensed to the Apache Software Foundation (ASF) under one | ||
# or more contributor license agreements. See the NOTICE file | ||
# distributed with this work for additional information | ||
# regarding copyright ownership. The ASF licenses this file | ||
# to you under the Apache License, Version 2.0 (the | ||
# "License"); you may not use this file except in compliance | ||
# with the License. You may obtain a copy of the License at | ||
# | ||
# http://www.apache.org/licenses/LICENSE-2.0 | ||
# | ||
# Unless required by applicable law or agreed to in writing, | ||
# software distributed under the License is distributed on an | ||
# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
# KIND, either express or implied. See the License for the | ||
# specific language governing permissions and limitations | ||
# under the License. | ||
# | ||
|
||
name: "CI :: Check license headers" | ||
|
||
on: | ||
pull_request: | ||
types: [opened, synchronize, reopened, ready_for_review] | ||
|
||
jobs: | ||
check-license-headers: | ||
runs-on: ubuntu-latest | ||
|
||
steps: | ||
- name: Checkout code | ||
uses: actions/checkout@v3 | ||
|
||
- name: Download Apache RAT | ||
run: | | ||
curl -LO https://repository.apache.org/content/repositories/snapshots/org/apache/rat/apache-rat/0.17-SNAPSHOT/apache-rat-0.17-20241115.065104-374.jar | ||
|
||
- name: Run Apache RAT | ||
run: | | ||
java -jar apache-rat-0.17-20241115.065104-374.jar --input-exclude-file .rat-excludes -- . > .tmp-rat-check-output | ||
cat .tmp-rat-check-output | ||
grep "Files with unapproved licenses:" .tmp-rat-check-output && rm .tmp-rat-check-output && echo "There are files with missing or unapproved license headers." && exit 1 || rm .tmp-rat-check-output && echo "All files have correct license headers." |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -40,4 +40,7 @@ target/ | |
.run/ | ||
.checkstyle | ||
|
||
*.log | ||
*.log | ||
|
||
# Apache RAT check excludes file | ||
!.rat-excludes |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,20 @@ | ||
### general excludes | ||
**/target/** | ||
**/.* | ||
*README* | ||
*readme* | ||
DISCLAIMER-WIP | ||
**/src/test/resources/** | ||
**/src/test/filtered-resources/** | ||
**/*integration-test*/src/main/resources/** | ||
**/**example**/**/resources/** | ||
**/META-INF/services/** | ||
**/META-INF/beans.xml | ||
**/licenses/** | ||
|
||
### kogito-runtimes specific excludes | ||
**/META-INF/kogito.addon | ||
**/*.avsc | ||
**/jbpm-tests/src/test/bpmn/** | ||
**/jbpm-bpmn2/**/*.xsd | ||
**/requirements.txt |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
20 changes: 20 additions & 0 deletions
20
jbpm/jbpm-deps-groups/jbpm-deps-group-bpmn2-compiler/pom.xml
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pjfanning Could kindly give an advice about this topic? For BPMN 2.0 xsd files, we are not very sure where to find the license for them. In this PR, we take "LICENSES" section from https://www.omg.org/spec/BPMN/2.0/PDF . Do you think it's okay?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would suggest creating a JIRA at https://issues.apache.org/jira/projects/LEGAL ? I am no expert but this doesn't look good to me - these terms seem unsafe for use by anyone other than Object Management Group, Inc. (OMG).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pjfanning Thanks. I filed https://issues.apache.org/jira/browse/LEGAL-690
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
License for DMN spec from OMG is also being worked on apache/incubator-kie-drools#6156