Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KOGITO-5941 Introduce changes to successfully run tests with JDK 17 #1607

Merged
merged 12 commits into from
Sep 23, 2021
Merged

KOGITO-5941 Introduce changes to successfully run tests with JDK 17 #1607

merged 12 commits into from
Sep 23, 2021

Conversation

triceo
Copy link
Contributor

@triceo triceo commented Sep 16, 2021 •
edited
Loading

Makes sure that the build passes when run on JDK 17.
https://issues.redhat.com/browse/KOGITO-5941

Please make sure that your PR meets the following requirements:

  • You have read the contributors guide
  • Your code is properly formatted according to this configuration
  • Pull Request title is properly formatted: KOGITO-XYZ Subject
  • Pull Request title contains the target branch if not targeting main: [0.9.x] KOGITO-XYZ Subject
  • Pull Request contains link to the JIRA issue
  • Pull Request contains link to any dependent or related Pull Request
  • Pull Request contains description of the issue
  • Pull Request does not include fixes for issues other than the main ticket
How to retest this PR or trigger a specific build:

  • Run all builds
    Please add comment: Jenkins retest this

  • Run (or rerun) specific test(s)
    Please add comment: Jenkins (re)run [runtimes|optaplanner|apps|examples] tests

  • Quarkus LTS checks
    Please add comment: Jenkins run LTS

  • Run (or rerun) LTS specific test(s)
    Please add comment: Jenkins (re)run [runtimes|optaplanner|apps|examples] LTS

  • Native checks
    Please add comment: Jenkins run native

  • Run (or rerun) native specific test(s)
    Please add comment: Jenkins (re)run [runtimes|optaplanner|apps|examples] native

  • Full Kogito testing (with cloud images and operator BDD testing)
    Please add comment: Jenkins run BDD
    This check should be used only if a big change is done as it takes time to run, need resources and one full BDD tests check can be done at a time ...

@triceo triceo changed the title Introduce changes to successfully run tests with JDK 17 KOGITO-5941 Introduce changes to successfully run tests with JDK 17 Sep 21, 2021
@kie-ci
Copy link
Contributor

kie-ci commented Sep 21, 2021

The (build) Apps check has failed. Please check the logs.

@kie-ci
Copy link
Contributor

kie-ci commented Sep 21, 2021

The (build) Apps check has failed. Please check the logs.

@triceo triceo marked this pull request as ready for review September 21, 2021 11:44
danielezonca
danielezonca reviewed Sep 21, 2021
View reviewed changes
Copy link
Contributor

@danielezonca danielezonca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR :)
Very few comments

...kus-gradle/integration-tests-quarkus-gradle-project/gradle/wrapper/gradle-wrapper.properties Outdated Show resolved Hide resolved
.github/workflows/runtimes-pr.yml Outdated Show resolved Hide resolved
jbpm/jbpm-flow-builder/pom.xml Outdated Show resolved Hide resolved
jbpm/jbpm-flow/pom.xml Outdated Show resolved Hide resolved
@kie-ci
Copy link
Contributor

kie-ci commented Sep 21, 2021

The (build) Apps check has failed. Please check the logs.

@triceo
Copy link
Contributor Author

triceo commented Sep 21, 2021

@evacchi Looking for a green review before I merge. Do you mind? :-)

@kie-ci
Copy link
Contributor

kie-ci commented Sep 21, 2021

The (build) Apps check has failed. Please check the logs.

@kie-ci
Copy link
Contributor

kie-ci commented Sep 21, 2021

The (build) Examples check has failed. Please check the logs.

cristianonicolai
cristianonicolai reviewed Sep 22, 2021
View reviewed changes
Copy link
Contributor

@cristianonicolai cristianonicolai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@triceo looks good to me, lets just decide with the team if we can drop the JavaScript support before merging this.

jbpm/jbpm-flow-builder/pom.xml Show resolved Hide resolved
jbpm/jbpm-flow/src/main/java/org/jbpm/process/instance/impl/JavaScriptAction.java Show resolved Hide resolved
@cristianonicolai
Copy link
Contributor

Jenkins rerun apps tests

@cristianonicolai
Copy link
Contributor

Jenkins rerun examples tests

@triceo triceo mentioned this pull request Sep 22, 2021
Merged
@ricardozanini
Copy link
Member

kiegroup_kogito_examples/kogito-examples/serverless-workflow-service-calls-quarkus/src/test/java/org/kogito/serverless/examples/CountryServiceWorkflowTest.java:61 | org.opentest4j.AssertionFailedError: expected: <2> but was: <5> at org.junit.jupiter.api.AssertionUtils.fail(AssertionUtils.java:55)

Looks like we have a test connecting to the webservice 🤦

I'll fix this test ASAP.

@kie-ci
Copy link
Contributor

kie-ci commented Sep 23, 2021

The (build) Examples check has failed. Please check the logs.

@sonarcloud
Copy link

sonarcloud bot commented Sep 23, 2021

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

77.8% 77.8% Coverage
0.0% 0.0% Duplication

@ricardozanini
Copy link
Member

kiegroup_kogito_examples/kogito-examples/serverless-workflow-service-calls-quarkus/src/test/java/org/kogito/serverless/examples/CountryServiceWorkflowTest.java:61 | org.opentest4j.AssertionFailedError: expected: <2> but was: <5> at org.junit.jupiter.api.AssertionUtils.fail(AssertionUtils.java:55)

Looks like we have a test connecting to the webservice

I'll fix this test ASAP.

Fixed https://github.com/kiegroup/kogito-examples/pull/898

@triceo triceo merged commit 568bd01 into apache:main Sep 23, 2021
@triceo triceo deleted the jdk17 branch September 23, 2021 17:47
@triceo
Copy link
Contributor Author

triceo commented Sep 23, 2021

Merged, thanks everyone for contributing and thank you @ricardozanini for fixing that test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jstastny-cz jstastny-cz jstastny-cz left review comments

@tiagodolphine tiagodolphine tiagodolphine left review comments

@yurloc yurloc yurloc left review comments

@cristianonicolai cristianonicolai cristianonicolai left review comments

@danielezonca danielezonca danielezonca left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@triceo @kie-ci @cristianonicolai @ricardozanini @danielezonca @yurloc @tiagodolphine @jstastny-cz