[KOGITO-4457] Removing knative-eventing-addon

[ricardozanini]

Signed-off-by: Ricardo Zanini [email protected]

See: https://issues.redhat.com/browse/KOGITO-4457

In this PR we completely remove knative-eventing-addon, a module added in the Dark Ages to give support to CloudEvents over HTTP.

Now, the Quarkus CloudEvents Addon automatically adds the possibility to consume CE in the application's root path. It also plays nicely with any Smallrye Connector. Meaning that the service can consume from any Smallrye implementation/connector and also from HTTP CE.

Requires https://github.com/kiegroup/kogito-runtimes/pull/1124
Once CI gets back, we merge #1124, I rebase and we will have a more stable code base regarding CE handling.

Many thanks for submitting your Pull Request ❤️!

Please make sure that your PR meets the following requirements:

• You have read the contributors guide
• Your code is properly formatted according to this configuration
• Pull Request title is properly formatted: KOGITO-XYZ Subject
• Pull Request title contains the target branch if not targeting master: [0.9.x] KOGITO-XYZ Subject
• Pull Request contains link to the JIRA issue
• Pull Request contains link to any dependent or related Pull Request
• Pull Request contains description of the issue
• Pull Request does not include fixes for issues other than the main ticket

How to retest this PR or trigger a specific build:

• Pull Request
  Please add comment: Jenkins retest this

• Quarkus LTS checks
  Please add comment: Jenkins run LTS

• Native checks
  Please add comment: Jenkins run native

• Full Kogito testing (with cloud images and operator BDD testing)
  Please add comment: Jenkins run BDD
  This check should be used only if a big change is done as it takes time to run, need resources and one full BDD tests check can be done at a time ...

[ricardozanini]

@fjtirado FYI

[ricardozanini]

Examples updated: https://github.com/kiegroup/kogito-examples/pull/643

[evacchi]

couple of minor changes

[fjtirado]

@ricardozanini thanks for sharing.
Just minor comestic issues
Although not part of this JIRA, since we are chaning kogitoProcessExtension, can we replace current getExtension implementation by

    private String getExtension(CloudEventExtensions extensions, String key) {
        return Objects.toString(extensions.getExtension(key));
    };

?

[ricardozanini]

@ricardozanini thanks for sharing.
Just minor comestic issues
Although not part of this JIRA, since we are chaning kogitoProcessExtension, can we replace current getExtension implementation by

    private String getExtension(CloudEventExtensions extensions, String key) {
        return Objects.toString(extensions.getExtension(key));
    };

?

I think it's better to leave as it's. If null we are returning an empty String instead of null String.

[fjtirado]

@ricardozanini thanks for sharing.
Just minor comestic issues
Although not part of this JIRA, since we are chaning kogitoProcessExtension, can we replace current getExtension implementation by

    private String getExtension(CloudEventExtensions extensions, String key) {
        return Objects.toString(extensions.getExtension(key));
    };

?

I think it's better to leave as it's. If null we are returning an empty String instead of null String.

Ok, you can use
private String getExtension(CloudEventExtensions extensions, String key) {
return Objects.toString(extensions.getExtension(key),"");
};

[ricardozanini]

LOL

[ricardozanini]

Jenkins retest this

[kie-ci]

The Linux check has failed. Please check the logs.

[kie-ci]

The Linux check has failed. Please check the logs.

[danielezonca]

@ricardozanini
Minor thing, can you please rename the PR? Deprecating is not correct considering that we are removing it completely

[kie-ci]

The Linux check has failed. Please check the logs.

[kie-ci]

The Linux check has failed. Please check the logs.

[ricardozanini]

Jenkins retest this

[kie-ci]

The Linux check is successful.

[cristianonicolai]

@ricardozanini needs rebase

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
1 Code Smell

No Coverage information
0.0% Duplication

[kie-ci]

The Linux check is successful.