Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DROOLS-3763: New API codegen prototype #1

Merged
merged 1 commit into from
Apr 1, 2019

Conversation

evacchi
Copy link
Contributor

@evacchi evacchi commented Mar 25, 2019

API we discussed together:

  • RuleUnit<T>/RuleUnitInstance<T>
  • one KieSession per RuleUnitInstance
  • generated Module class with code-generated create${T}RuleUnit()
  • refactored Maven plugin

see examples for reference apache/incubator-kie-kogito-examples#5

@lucamolteni
Copy link
Contributor

Was the "Simple" untyped <Object> Unit implemented?

@evacchi
Copy link
Contributor Author

evacchi commented Mar 25, 2019

not yet, I'll add it soon. We'll have to think a little bit about implication (if it's library-based you can't "discover it" as source code but look in classpath etc etc)

@mariofusco mariofusco closed this Mar 27, 2019
@mariofusco mariofusco reopened this Mar 27, 2019
@evacchi evacchi force-pushed the DROOLS-3763-codegen branch from 6fe8148 to 6aef805 Compare March 27, 2019 12:59
@evacchi
Copy link
Contributor Author

evacchi commented Apr 1, 2019

after discussion with @mariofusco I am merging this.

@evacchi evacchi merged commit 48b9e01 into apache:master Apr 1, 2019
tarilabs pushed a commit that referenced this pull request Apr 7, 2019
* avoid reflection in node, context factories; disable ScriptManager in SVM

* remove ScriptFactory for SVM compat

* test: should not check node factory for Class type

* @ignore tests using DataTransformers
tiagodolphine referenced this pull request in tiagodolphine/kogito-runtimes Nov 16, 2019
* Initial Job Service implementation

Initial Job Service implementation

inserting swagger

* Apply PR comments and some code refactoring, test

* Fix JobScheduler when cancelling job

* Fixing cancel already scheduled job when re-scheduling
mswiderski added a commit that referenced this pull request Jan 13, 2020
* KOGITO-590: Rules should "see" process variables

* add test case

* fix

* rm comments

* fix npe in model tests

* address comments, cleanup imports

* disable test

* add support for additional operations on process variables from rule unit's data sources (#1)

Co-authored-by: Maciej Swiderski <swiderski.maciej@gmail.com>
@tkobayas tkobayas mentioned this pull request Dec 6, 2023
rgdoliveira added a commit to rgdoliveira/kogito-runtimes that referenced this pull request Jan 17, 2024
Sync main branch with main-apache branch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants