-
Notifications
You must be signed in to change notification settings - Fork 79
[KOGITO-165] - Kogito Runtime Services integration with Infinispan #116
Conversation
Infinispan being accessed successfully via onboarding example:
Use the following onboarding CR: apiVersion: app.kiegroup.org/v1alpha1
kind: KogitoApp
metadata:
name: onboarding-service
namespace: kogito
spec:
build:
env:
- name: MAVEN_MIRROR_URL
value:
- name: MAVEN_ARGS_APPEND
value: -Ppersistence
gitSource:
contextDir: onboarding-example/onboarding
reference: infinispan-props
uri: https://github.com/ricardozanini/kogito-examples
imageRuntime:
imageStreamTag: 0.6.0-rc1
imageS2I:
imageStreamTag: 0.6.0-rc1
resources: {}
env:
- name: NAMESPACE
value: kogito
infra:
installInfinispan: Always
resources: {}
runtime: quarkus
service:
labels:
onboarding: process And of course the payroll and hr services also have to be deployed. |
Regarding the requirement of having properties set in the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code seems ok to me. I am going to test a bit :)
535c8d1
to
3fcb575
Compare
@xiezhang7 @spolti could you guys please review? I intend to merge this by Monday EOD to start working on others JIRAs that depend on this one. Many thanks! |
3fcb575
to
b9c0a02
Compare
deploy/olm-catalog/kogito-cloud-operator/0.6.0/app.kiegroup.org_kogitoapps_crd.yaml
Show resolved
Hide resolved
90f5574
to
1258d56
Compare
@radtriste as soon as you finish your tests, please report back so we can decide if should be merged. |
0781c56
to
6e8f86e
Compare
6e8f86e
to
8e9efbc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems good to me.
Tested with CLI and CR file.
CLI command used (for onboarding service):
kogito deploy-service onboarding-service https://github.com/kiegroup/kogito-examples/ --context-dir=onboarding-example/onboarding --install-infinispan=Always --incremental-build --build-env MAVEN_ARGS_APPEND=-Ppersistence -e NAMESPACE=kogito-165
TODO:
------------ 8< -------------
See:
https://issues.jboss.org/browse/KOGITO-165
In this PR:
KogitoApp
:Infra.InstallInfinispan
.Always
means that the operator should always install a Infinispan instance;Never
won't install, even if requires - the user will provision and configure their own installation;Auto
will try to figure out scanning image metadataThe only problem I saw is that if the service doesn't set the infinispan properties in the
application.properties
, won't work since Quarkus is not reading from env. See a working example here: https://github.com/ricardozanini/kogito-examples/blob/infinispan-props/onboarding-example/onboarding/src/main/resources/application.properties#L4-L6@mswiderski is this a problem? We can set the
-D
in the images if the envs where found in the container. For Quarkus:@mswiderski one more thing, the onboarding example is failing (I just deployed the onboarding, not the others services): https://pastebin.com/AHXuMRPu. Fixed, to work all three services must be running.Is this the expected behavior? Tomorrow I'll try to deploy the other services.Many thanks for submiting your Pull Request ❤️!
Please make sure that your PR meets the following requirements:
[KOGITO-XYZ] Subject