Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KOGITO-6085 Public API: Examples should use MapDataContext.of(Map) #920

Merged
merged 2 commits into from
Oct 11, 2021
Merged

KOGITO-6085 Public API: Examples should use MapDataContext.of(Map) #920

merged 2 commits into from
Oct 11, 2021

Conversation

evacchi
Copy link
Contributor

@evacchi evacchi commented Oct 7, 2021 •
edited
Loading

  • Incubation API should use MapDataContext.of(Map)

@evacchi evacchi changed the base branch from stable to main October 7, 2021 07:41
@evacchi evacchi changed the title incub api dcof Incubation API should use MapDataContext.of(Map) Oct 7, 2021
@evacchi evacchi marked this pull request as ready for review October 8, 2021 13:59
tarilabs
tarilabs approved these changes Oct 11, 2021
View reviewed changes
Copy link
Member

@tarilabs tarilabs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm thanks to what we discussed, maybe you wanted to ask for review of the different SMEs?

@evacchi
Copy link
Contributor Author

evacchi commented Oct 11, 2021

@tarilabs it's a minor detail so I just wanted to page you FYI :)

@evacchi evacchi changed the title Incubation API should use MapDataContext.of(Map) KOGITO-6085 Public API: Examples should use MapDataContext.of(Map) Oct 11, 2021
@evacchi evacchi merged commit 04e2bfb into apache:main Oct 11, 2021
@evacchi evacchi deleted the incub-api-dcof branch October 11, 2021 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@radtriste radtriste radtriste approved these changes

@tarilabs tarilabs tarilabs approved these changes

@danielezonca danielezonca danielezonca approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@evacchi @danielezonca @tarilabs @radtriste