Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FAI-243 - improved type dependent perturbations #467

Merged
merged 8 commits into from
Oct 12, 2020
Merged

FAI-243 - improved type dependent perturbations #467

merged 8 commits into from
Oct 12, 2020

Conversation

tteofili
Copy link
Contributor

Added more appropriate perturbations depending on the specific feature Type.

see https://issues.redhat.com/browse/FAI-243

Many thanks for submitting your Pull Request ❤️!

Please make sure that your PR meets the following requirements:

  • You have read the contributors guide
  • Pull Request title is properly formatted: KOGITO-XYZ Subject
  • Pull Request title contains the target branch if not targeting master: [0.9.x] KOGITO-XYZ Subject
  • Pull Request contains link to the JIRA issue
  • Pull Request contains link to any dependent or related Pull Request
  • Pull Request contains description of the issue
  • Pull Request does not include fixes for issues other than the main ticket

@tteofili
Copy link
Contributor Author

jenkins retest this please

danielezonca
danielezonca reviewed Sep 29, 2020
View reviewed changes
Copy link
Contributor

@danielezonca danielezonca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding some comments, can you please improve test coverage of Type class?
https://sonarcloud.io/component_measures?id=org.kie.kogito%3Akogito-apps&metric=new_coverage&pullRequest=467&selected=org.kie.kogito%3Akogito-apps%3Aexplainability%2Fexplainability-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fkie%2Fkogito%2Fexplainability%2Fmodel%2FType.java&view=list
There are many corner cases/exit conditions not covered

explainability/explainability-core/src/main/java/org/kie/kogito/explainability/model/Type.java Show resolved Hide resolved
explainability/explainability-core/src/main/java/org/kie/kogito/explainability/model/Type.java Outdated Show resolved Hide resolved
@tteofili
Copy link
Contributor Author

jenkins retest this please

@tteofili
Copy link
Contributor Author

tteofili commented Oct 1, 2020

jenkins retest this please

@tteofili
Copy link
Contributor Author

tteofili commented Oct 1, 2020

again failing on ui-packages, triggering new CI build.

@tteofili
Copy link
Contributor Author

tteofili commented Oct 1, 2020

jenkins retest this please

danielezonca
danielezonca approved these changes Oct 5, 2020
View reviewed changes
Copy link
Contributor

@danielezonca danielezonca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tteofili
Copy link
Contributor Author

tteofili commented Oct 5, 2020

jenkins retest this please

1 similar comment
@tteofili
Copy link
Contributor Author

tteofili commented Oct 5, 2020

jenkins retest this please

@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 5, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 4 Code Smells

96.2% 96.2% Coverage
0.0% 0.0% Duplication

jiripetrlik
jiripetrlik approved these changes Oct 12, 2020
View reviewed changes
Copy link
Contributor

@jiripetrlik jiripetrlik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@danielezonca danielezonca merged commit 6c364e9 into apache:master Oct 12, 2020
almope pushed a commit to almope/kogito-apps that referenced this pull request Oct 7, 2021
@r00ta
Update trusty demo to 1.0 (apache#467)
315a92e 
* update to trusty 1.0

* update readme
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jiripetrlik jiripetrlik jiripetrlik approved these changes

@danielezonca danielezonca danielezonca approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tteofili @danielezonca @jiripetrlik