-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
KOGITO-3208: integration test for trusty service and explainability service #458
Conversation
e9a21a2
to
463ea19
Compare
463ea19
to
1219103
Compare
jenkins retest this please |
1 similar comment
jenkins retest this please |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have first few comments and questions.
...ation-tests/integration-tests-trusty-service/integration-tests-trusty-service-common/pom.xml
Show resolved
Hide resolved
...ice-common/src/main/java/org/kie/kogito/it/trusty/AbstractTrustyExplainabilityEnd2EndIT.java
Outdated
Show resolved
Hide resolved
...ice-common/src/main/java/org/kie/kogito/it/trusty/AbstractTrustyExplainabilityEnd2EndIT.java
Outdated
Show resolved
Hide resolved
...ice-common/src/main/java/org/kie/kogito/it/trusty/AbstractTrustyExplainabilityEnd2EndIT.java
Outdated
Show resolved
Hide resolved
...ation-tests/integration-tests-trusty-service/integration-tests-trusty-service-common/pom.xml
Show resolved
Hide resolved
...ice-common/src/main/java/org/kie/kogito/it/trusty/AbstractTrustyExplainabilityEnd2EndIT.java
Outdated
Show resolved
Hide resolved
...ervice/integration-tests-trusty-service-springboot/src/main/resources/application.properties
Outdated
Show resolved
Hide resolved
trusty/trusty-service/src/main/resources/application.properties
Outdated
Show resolved
Hide resolved
...tion-tests/integration-tests-trusty-service/integration-tests-trusty-service-quarkus/pom.xml
Show resolved
Hide resolved
...tion-tests/integration-tests-trusty-service/integration-tests-trusty-service-quarkus/pom.xml
Show resolved
Hide resolved
...n-tests/integration-tests-trusty-service/integration-tests-trusty-service-springboot/pom.xml
Show resolved
Hide resolved
...n-tests/integration-tests-trusty-service/integration-tests-trusty-service-springboot/pom.xml
Outdated
Show resolved
Hide resolved
...n-tests/integration-tests-trusty-service/integration-tests-trusty-service-springboot/pom.xml
Outdated
Show resolved
Hide resolved
Co-authored-by: Daniele Zonca <[email protected]>
trusty/trusty-service/src/main/resources/application.properties
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR approving 👍
jenkins retest this please |
SonarCloud Quality Gate failed. 2 Bugs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @kostola thank you for your changes. Looks good to me now.
* remove config listeners * rename config property * add process metrics test * rename config property * removed wrong file * remove Interceptor * update readme * rename monitoring modules * remove files
Goal
Simulate the complete flow between a Kogito service exposing a DMN model, the Trusty Service and the Explainability Service:
TraceEvent
and sends it to Kafka.TraceEvent
, stores the information about the execution in Infinispan.Main contents
integration-tests-trusty-service-quarkus
andintegration-tests-trusty-service-springboot
) and a common module (integration-tests-trusty-service-common
) with the shared logic, all grouped in a submodule ofintegration-tests
calledintegration-tests-trusty-service
.integration-tests
implemented specific tests forjobs-service
. I renamed them adding thejobs-service
part and moved to a dedicated submodule. One of the reason is a specific behavior ofQuarkusTestResourceLifecycleManager
classes (explained here).AbstractTrustyExplainabilityEnd2EndIT
instead ofConditionalQuarkusTestResource
andConditionalSpringBootTestResource
because I need to start containers in a specific order and they must communicate between each other (so they must belong to the same bridged network). I tried using*TestResource
but I could not manage to implement the complete flow and the code was becoming a mess.