[incubator-kie-issues-1613] Add .rat-excludes file to each repository #6149
Conversation
tkobayas
force-pushed
the
rat-excludes
branch
3 times, most recently
from
f164a69
to
5095a4d
Compare
tkobayas
force-pushed
the
rat-excludes
branch
from
5095a4d
to
3febb80
Compare
|
|
||
| - name: Run Apache RAT | ||
| run: | | ||
| java -jar apache-rat-0.16.1.jar -d . -E .rat-excludes | grep "== File:" && echo "The files listed above are missing license headers." && exit 1 || echo "All files have license headers." |
There was a problem hiding this comment.
If a file doesn't have a license header and it's not listed in .rat-excludes, this GHA fails.
pom.xml
Outdated
| <configuration> | ||
| <excludes> | ||
| <exclude>.rat-excludes</exclude> | ||
| <exclude>.gitignore</exclude> | ||
| <exclude>DISCLAIMER-WIP</exclude> | ||
| <exclude>**/ui-bundle.zip</exclude> |
There was a problem hiding this comment.
Unfortunately, we cannot share the same .rat-excludes file for java -jar apache-rat-0.16.1.jar -E command line and <excludesFile> in apache-rat-plugin, because command line expects that the exclude files is written with regular expression (e.g. .*\.csv) while apache-rat-plugin expects the exclude files is written with glob pattern (e.g. **/*.csv). Maintaining both configurations is a little cumbersome.
With this PR, we can check license headers with GHA and also with command line locally. Shall I remove apache-rat-plugin from pom.xml? @baldimir
There was a problem hiding this comment.
Sure, I am fine removing the plugin.
There was a problem hiding this comment.
Thanks. Removing the plugin...
|
GHA kogito-runtimes : flaky. reported in zulip https://kie.zulipchat.com/#narrow/channel/382044-kogito-dev/topic/StandaloneBPMNProcessTest.2EtestEventBasedSplit2.20is.20flaky |
| * antora ui-bundle | ||
| Downloaded from: https://github.com/stephengold/antora-ui-bundle | ||
| License: Mozilla Public License 2.0 |
There was a problem hiding this comment.
cool, thank you for keeping mind to update all aspects of the codebase, just sharing, you probably noticed already, we will need to refactor and move content from NOTICE to LICENSE apache/incubator-kie-issues#1616 and apache/incubator-kie-issues#1618
There was a problem hiding this comment.
Thank you for the heads-up!
…apache#6149) * [incubator-kie-issues-1613] Add .rat-excludes file to each repository * removing apache-rat-plugin as we can check it with command line
…apache#6149) * [incubator-kie-issues-1613] Add .rat-excludes file to each repository * removing apache-rat-plugin as we can check it with command line
…10.0.x (#6167) * [incubator-kie-issues-1613] Add .rat-excludes file to each repository (#6149) * [incubator-kie-issues-1613] Add .rat-excludes file to each repository * removing apache-rat-plugin as we can check it with command line * [incubator-kie-issues-1616] notice file for drools is not correct (#6153) * [incubator-kie-issues-1616] notice file for drools is not correct * fix .rat-excludes * consolidate LICENSE files to single LICENSE file * fixed missing license header * fix CsvLineParser license * exclude drools-docs related licenses, because they will not be included in source distoribution * [NO-ISSUE] mvel.jj license (#6164) * [NO-ISSUE] mvel.jj license * - adjust words * - fixed a period * adding OMG XSD files License info (#6156) * adding OMG XSD files License info * fixing rat-excludes and adjusting file list of OMG files * adjusted trisotech related license and copyright info * - adjust .rat-excludes * adjust .rat-excludes * update .rat-excludes to list every single file * fix license headers * fix sysout --------- Co-authored-by: Alex Porcelli <[email protected]>
Issue: