Put some unsolvable tests into methods filter #714
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
refer #648 |
Codecov Report
@@ Coverage Diff @@
## master #714 +/- ##
==========================================
+ Coverage 71.32% 73.32% +2%
- Complexity 4346 4507 +161
==========================================
Files 281 281
Lines 20762 20843 +81
Branches 2925 2956 +31
==========================================
+ Hits 14808 15283 +475
+ Misses 4503 4127 -376
+ Partials 1451 1433 -18
Continue to review full report at Codecov.
|
javeme
reviewed
Oct 24, 2019
hugegraph-test/src/main/java/com/baidu/hugegraph/tinkerpop/ProcessBasicSuite.java
Outdated
Show resolved
Hide resolved
Linary
force-pushed
the
tinkerpop-tests
branch
2 times, most recently
from
a153d25 to
d3034e4
Compare
|
RocksDB CI error:
|
|
Cassandra CI error: Cassandra CI error: |
Linary
force-pushed
the
tinkerpop-tests
branch
from
d3034e4 to
99c5eed
Compare
|
Error after upgrading v6.3.6 one time one time one time one time |
Linary
force-pushed
the
tinkerpop-tests
branch
2 times, most recently
from
6034e22 to
c221905
Compare
javeme
added a commit
that referenced
this pull request
Nov 4, 2019
also upgraded deprecated options like: max_background_jobs and add some options: * max_total_wal_size * db_write_buffer_size * delete_obsolete_files_period related: #714 Change-Id: I693a8d4550110280c46f0c40da6b4e42ad540eb3
|
rocksdb version: 6.3.6 public class TestIteratorAfterCloseCF {
public static void main(String args[]) throws Exception {
RocksDB rocksdb = testReleaseIteratorAfterCloseCF();
println("gc for Iterator before");
System.gc(); Thread.sleep(1000 * 2);
println("gc for Iterator after");
System.gc(); Thread.sleep(1000 * 2);
println("gc2 for Iterator after");
System.gc(); Thread.sleep(1000 * 2);
println("gc3 for Iterator after");
println("close rocksdb");
rocksdb.close();
System.gc(); Thread.sleep(1000 * 2);
println("done");
}
public static RocksDB testReleaseIteratorAfterCloseCF() throws Exception {
String path = "rocksdb-data";
FileUtils.deleteDirectory(new File(path));
DBOptions options = new DBOptions();
options.setWalDir(path);
options.setCreateIfMissing(true);
List<ColumnFamilyDescriptor> cfds = new ArrayList<>();
cfds.add(new ColumnFamilyDescriptor("default".getBytes()));
List<ColumnFamilyHandle> cfhs = new ArrayList<>();
RocksDB rocksdb = RocksDB.open(options, path, cfds, cfhs);
ColumnFamilyDescriptor cfd = new ColumnFamilyDescriptor("cf".getBytes());
println("create CF");
ColumnFamilyHandle cfHandle = rocksdb.createColumnFamily(cfd);
println("new Iterator");
RocksIterator iter = rocksdb.newIterator(cfHandle);
iter.seekToFirst();
// iter.close(); // it's no coredump if manually closed here
println("drop CF");
rocksdb.dropColumnFamily(cfHandle); // effect when close
println("close CF");
cfHandle.close(); // <== assertion failed: (is_last_reference) here in v6.3.6, it's ok in v5.14.2
println("closed CF");
iter.close();
cfhs.clear(); System.gc(); Thread.sleep(1000);
return rocksdb;
}
private static void println(String line) {
System.out.println(line);
System.out.flush();
}
} |
Linary
pushed a commit
that referenced
this pull request
Nov 6, 2019
also upgraded deprecated options like: max_background_jobs and add some options: * max_total_wal_size * db_write_buffer_size * delete_obsolete_files_period related: #714 Change-Id: I693a8d4550110280c46f0c40da6b4e42ad540eb3
Change-Id: Id853ede1bf8277ba2b942e3c502257e78ec23617
Change-Id: Ifd22b539fef78326a83c5dfd6b91c0a80c6711a0
Change-Id: Ic96f548cab329b59f23ed4034ce5ec49c1fe42d2
Linary
force-pushed
the
tinkerpop-tests
branch
from
c221905 to
38f5759
Compare
Change-Id: I41edc48fa5e63990a47e4c409356cc7cd4a3a43d
Linary
force-pushed
the
tinkerpop-tests
branch
from
38f5759 to
2fc9759
Compare
HBase后端structure两个测试failed
|
|
HBase 错误为sessions计数不对，第一次打开没有+1，修复办法为： |
Change-Id: I2d15273dd416a3210a0b19f4cf08507bdb1c2847
Change-Id: Ib2d207fc86072bd59a937849992b5148d5703007
Linary
force-pushed
the
tinkerpop-tests
branch
from
eb1e129 to
3334dcf
Compare
javeme
reviewed
Nov 7, 2019
| @@ -81,8 +81,7 @@ | |||
| FeatureSupportTest.class, | |||
| IoCustomTest.class, | |||
| IoEdgeTest.class, | |||
| // TODO: Open it when rocksdb bug fixed | |||
| // IoGraphTest.class, | |||
| IoGraphTest.class, | |||
| @@ -30,11 +30,15 @@ script: | |||
| fi | |||
| - | | |||
| if [[ "$TRAVIS_BRANCH" =~ $RELEASE_BRANCH ]]; then | |||
| mvn test -P tinkerpop-structure-test,$BACKEND | |||
| if [[ "$BACKEND" != "rocksdb" && "$BACKEND" != "hbase" ]]; then | |||
| mvn test -P tinkerpop-structure-test,$BACKEND | |||
zhoney
previously approved these changes
Nov 7, 2019
javeme
previously approved these changes
Nov 7, 2019
Linary
force-pushed
the
tinkerpop-tests
branch
from
fe21316 to
a68b004
Compare
Change-Id: If847b05f35b00145f3f3febd88162e41ab030fb6
Linary
force-pushed
the
tinkerpop-tests
branch
from
a68b004 to
b52190d
Compare
javeme
approved these changes
Nov 8, 2019
zhoney
approved these changes
Nov 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change-Id: Id853ede1bf8277ba2b942e3c502257e78ec23617