Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add cache options for rocksdb #567

Merged
merged 2 commits into from
Jun 26, 2019
Merged

add cache options for rocksdb #567

merged 2 commits into from
Jun 26, 2019

Conversation

javeme
Copy link
Contributor

@javeme javeme commented Jun 13, 2019

Change-Id: Icc4ae746f3117905960b8de52ae59386e0684584

conf.get(RocksDBOptions.COMPRESSION_TYPES);
E.checkArgument(compressions.isEmpty() ||
compressions.size() == numLevels,
"Elements number of '%s' must be the same as '%s'" +
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same as num levels

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This intent has been provided by RocksDBOptions.NUM_LEVELS.name()

Change-Id: Icc4ae746f3117905960b8de52ae59386e0684584
@javeme javeme force-pushed the rocksdb_add_cache_options branch from 0ff6964 to f866e76 Compare June 18, 2019 08:11
@codecov
Copy link

codecov bot commented Jun 18, 2019

Codecov Report

Merging #567 into master will increase coverage by 0.04%.
The diff coverage is 88.33%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #567      +/-   ##
============================================
+ Coverage     70.38%   70.43%   +0.04%     
  Complexity     3450     3450              
============================================
  Files           216      216              
  Lines         16535    16585      +50     
  Branches       2355     2360       +5     
============================================
+ Hits          11638    11681      +43     
- Misses         3653     3656       +3     
- Partials       1244     1248       +4
Impacted Files Coverage Δ Complexity Δ
.../main/java/com/baidu/hugegraph/cmd/ConfDumper.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...ugegraph/backend/store/rocksdb/RocksDBOptions.java 99.01% <100%> (+0.31%) 2 <0> (ø) ⬇️
...raph/backend/store/rocksdb/RocksDBStdSessions.java 69.54% <80.64%> (-0.12%) 24 <0> (ø)
...a/com/baidu/hugegraph/backend/query/Condition.java 65.07% <0%> (+0.52%) 23% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b9763c6...a1b08c0. Read the comment docs.

Linary
Linary previously approved these changes Jun 18, 2019
Change-Id: I4eb88b658165409516ecb9ee94ba8bec2ffc21fd
@zhoney zhoney merged commit f7a619f into master Jun 26, 2019
@zhoney zhoney deleted the rocksdb_add_cache_options branch June 26, 2019 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants