Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix existDatabase(), clearBackend() and rollback() for postgresql #531

Merged
merged 11 commits into from
Jun 12, 2019

Conversation

zhoney
Copy link
Contributor

@zhoney zhoney commented May 28, 2019

fixed: #530

Change-Id: I5061eb95abf0e0ef3a6a83a74ced291647d9308d

@codecov
Copy link

codecov bot commented May 28, 2019

Codecov Report

Merging #531 into master will increase coverage by 0.21%.
The diff coverage is 73.17%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #531      +/-   ##
============================================
+ Coverage     70.22%   70.44%   +0.21%     
- Complexity     3418     3444      +26     
============================================
  Files           216      216              
  Lines         16465    16487      +22     
  Branches       2351     2352       +1     
============================================
+ Hits          11563    11614      +51     
+ Misses         3646     3629      -17     
+ Partials       1256     1244      -12
Impacted Files Coverage Δ Complexity Δ
...n/java/com/baidu/hugegraph/config/CoreOptions.java 98.59% <ø> (ø) 2 <0> (ø) ⬇️
...src/main/java/com/baidu/hugegraph/HugeFactory.java 68% <100%> (+20.17%) 6 <0> (+2) ⬆️
...backend/store/postgresql/PostgresqlSerializer.java 87.5% <100%> (+4.89%) 6 <0> (ø) ⬇️
...u/hugegraph/backend/store/mysql/MysqlSessions.java 70.85% <66.66%> (-0.06%) 20 <4> (+2)
...h/backend/store/postgresql/PostgresqlSessions.java 70.27% <76.47%> (+5.27%) 8 <3> (+3) ⬆️
...a/com/baidu/hugegraph/backend/query/Condition.java 64.55% <0%> (-0.53%) 23% <0%> (ø)
...n/java/com/baidu/hugegraph/task/TaskScheduler.java 52.28% <0%> (-0.42%) 26% <0%> (-1%)
...raph/backend/store/rocksdb/RocksDBStdSessions.java 69.84% <0%> (+0.61%) 24% <0%> (+1%) ⬆️
.../backend/store/cassandra/CassandraSessionPool.java 59.37% <0%> (+1.04%) 13% <0%> (ø) ⬇️
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 033c387...5e67064. Read the comment docs.

@zhoney zhoney force-pushed the clear-commit branch 2 times, most recently from 02945c9 to f88d047 Compare May 28, 2019 11:39
Linary
Linary previously approved these changes May 31, 2019
zhoney added 7 commits June 6, 2019 17:08
fixed: #530

Change-Id: I5061eb95abf0e0ef3a6a83a74ced291647d9308d
Change-Id: Ib67261388516884dd2f376eaa95d6437d8d1d2c1
Change-Id: I3e9d7b416360d190faf4e09e0aa06382baff05ba
Change-Id: I25da367b644a8c20d4f07e023de66cc136eb0192
Change-Id: I8107e4ffef6b1c64696266cbd8309329d666c62c
Change-Id: I915a5cfea40fca960365eff5d2e83b2aa1f8a0f0
Change-Id: Ic4b7b5cc5315f8417712307431c86fa73ec6ab6c
Change-Id: Ifdb8e9b4d5703259da14cfc933b2c87e36c9f1fa
zhoney added 3 commits June 11, 2019 15:51
Change-Id: Ifb3caf3124932aef9bb1beb1e4ec2d58e40ac7c6
Change-Id: I248bc00db991a6fa4779134410e307240f13d465
Also check if auto-commit when calling execute() for mysql

Change-Id: Ia6cc5163fa0c01b3c44b0afed2d51799c47f6f97
@Linary Linary merged commit 928db07 into master Jun 12, 2019
@Linary Linary deleted the clear-commit branch June 12, 2019 02:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Postgresql existDatabase(), dropDatabase() and rollback() not work
3 participants