-
Notifications
You must be signed in to change notification settings - Fork 521
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix existDatabase(), clearBackend() and rollback() for postgresql #531
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #531 +/- ##
============================================
+ Coverage 70.22% 70.44% +0.21%
- Complexity 3418 3444 +26
============================================
Files 216 216
Lines 16465 16487 +22
Branches 2351 2352 +1
============================================
+ Hits 11563 11614 +51
+ Misses 3646 3629 -17
+ Partials 1256 1244 -12
Continue to review full report at Codecov.
|
zhoney
force-pushed
the
clear-commit
branch
2 times, most recently
from
May 28, 2019 11:39
02945c9
to
f88d047
Compare
Linary
previously approved these changes
May 31, 2019
javeme
requested changes
Jun 2, 2019
...ostgresql/src/main/java/com/baidu/hugegraph/backend/store/postgresql/PostgresqlSessions.java
Outdated
Show resolved
Hide resolved
...ostgresql/src/main/java/com/baidu/hugegraph/backend/store/postgresql/PostgresqlSessions.java
Outdated
Show resolved
Hide resolved
hugegraph-mysql/src/main/java/com/baidu/hugegraph/backend/store/mysql/MysqlSessions.java
Outdated
Show resolved
Hide resolved
javeme
requested changes
Jun 5, 2019
...ostgresql/src/main/java/com/baidu/hugegraph/backend/store/postgresql/PostgresqlSessions.java
Outdated
Show resolved
Hide resolved
hugegraph-test/src/main/java/com/baidu/hugegraph/core/MultiGraphsTest.java
Show resolved
Hide resolved
javeme
requested changes
Jun 5, 2019
hugegraph-test/src/main/java/com/baidu/hugegraph/core/MultiGraphsTest.java
Outdated
Show resolved
Hide resolved
hugegraph-test/src/main/java/com/baidu/hugegraph/core/MultiGraphsTest.java
Show resolved
Hide resolved
hugegraph-test/src/main/java/com/baidu/hugegraph/core/MultiGraphsTest.java
Outdated
Show resolved
Hide resolved
javeme
requested changes
Jun 5, 2019
hugegraph-test/src/main/java/com/baidu/hugegraph/core/MultiGraphsTest.java
Outdated
Show resolved
Hide resolved
fixed: #530 Change-Id: I5061eb95abf0e0ef3a6a83a74ced291647d9308d
Change-Id: I8107e4ffef6b1c64696266cbd8309329d666c62c
Change-Id: I915a5cfea40fca960365eff5d2e83b2aa1f8a0f0
Change-Id: Ic4b7b5cc5315f8417712307431c86fa73ec6ab6c
javeme
requested changes
Jun 10, 2019
hugegraph-test/src/main/java/com/baidu/hugegraph/core/MultiGraphsTest.java
Show resolved
Hide resolved
hugegraph-test/src/main/java/com/baidu/hugegraph/core/MultiGraphsTest.java
Show resolved
Hide resolved
...ostgresql/src/main/java/com/baidu/hugegraph/backend/store/postgresql/PostgresqlSessions.java
Outdated
Show resolved
Hide resolved
Change-Id: Ifdb8e9b4d5703259da14cfc933b2c87e36c9f1fa
javeme
requested changes
Jun 11, 2019
...tgresql/src/main/java/com/baidu/hugegraph/backend/store/postgresql/PostgresqlSerializer.java
Outdated
Show resolved
Hide resolved
...ostgresql/src/main/java/com/baidu/hugegraph/backend/store/postgresql/PostgresqlSessions.java
Outdated
Show resolved
Hide resolved
Change-Id: Ifb3caf3124932aef9bb1beb1e4ec2d58e40ac7c6
Change-Id: I248bc00db991a6fa4779134410e307240f13d465
Also check if auto-commit when calling execute() for mysql Change-Id: Ia6cc5163fa0c01b3c44b0afed2d51799c47f6f97
javeme
approved these changes
Jun 11, 2019
Linary
approved these changes
Jun 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixed: #530
Change-Id: I5061eb95abf0e0ef3a6a83a74ced291647d9308d