Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add source_in_ring args for rings API #528

Merged
merged 4 commits into from
Jul 1, 2019
Merged

Add source_in_ring args for rings API #528

merged 4 commits into from
Jul 1, 2019

Conversation

zhoney
Copy link
Contributor

@zhoney zhoney commented May 25, 2019

fixed: #523

Change-Id: If8c5cc4d8678f847ce4a5f0388e56aae465d3ea6

@codecov
Copy link

codecov bot commented May 25, 2019

Codecov Report

Merging #528 into master will increase coverage by 0.16%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #528      +/-   ##
============================================
+ Coverage     70.19%   70.36%   +0.16%     
- Complexity     3418     3449      +31     
============================================
  Files           216      216              
  Lines         16461    16533      +72     
  Branches       2351     2355       +4     
============================================
+ Hits          11555    11633      +78     
- Misses         3650     3658       +8     
+ Partials       1256     1242      -14
Impacted Files Coverage Δ Complexity Δ
.../baidu/hugegraph/backend/store/BackendSession.java 82.35% <0%> (-7.65%) 8% <0%> (+2%)
...c/main/java/com/baidu/hugegraph/util/JsonUtil.java 52.83% <0%> (-5.67%) 4% <0%> (-1%)
...u/hugegraph/backend/store/mysql/MysqlSessions.java 69.27% <0%> (-0.85%) 20% <0%> (+3%)
...du/hugegraph/backend/store/BackendSessionPool.java 82.14% <0%> (-0.47%) 15% <0%> (+2%)
...n/java/com/baidu/hugegraph/task/TaskScheduler.java 52.28% <0%> (-0.42%) 26% <0%> (-1%)
...h/backend/store/rocksdbsst/RocksDBSstSessions.java 0% <0%> (ø) 0% <0%> (ø) ⬇️
...gegraph/backend/store/rocksdb/RocksDBSessions.java 100% <0%> (ø) 1% <0%> (ø) ⬇️
...java/com/baidu/hugegraph/dist/HugeGraphServer.java 0% <0%> (ø) 0% <0%> (ø) ⬇️
...n/java/com/baidu/hugegraph/config/CoreOptions.java 98.64% <0%> (+0.05%) 2% <0%> (ø) ⬇️
...aidu/hugegraph/backend/store/mysql/MysqlTable.java 76.84% <0%> (+0.07%) 70% <0%> (ø) ⬇️
... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f3a3c35...c649e26. Read the comment docs.

@zhoney zhoney changed the title Rays contains paths reaching depth and no loop Add sourceInRing args for rings May 28, 2019
zhoney added 2 commits June 5, 2019 12:02
fixed: #523

Change-Id: If8c5cc4d8678f847ce4a5f0388e56aae465d3ea6
Change-Id: Ie99226fbb53fb3827887b76cdc4949cf018c7440
Change-Id: I9834c43a2c04c120844cf77029c8cc0e2af02076
@javeme javeme changed the title Add sourceInRing args for rings Add source_in_ring args for rings API Jun 5, 2019
}
}
}
assert count == 1;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems count maybe = 0

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there already exists one edge connected to 'target', so count must be >= 1, false means count == 1

Change-Id: I88fbcfa83ed5259f20997dbbf0b1c752eac494b4
@javeme javeme merged commit 8d23665 into master Jul 1, 2019
@javeme javeme deleted the fix-rays branch July 1, 2019 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HugeGraph 0.9.2版本rays操作指定Direction.BOTH返回结果为空
3 participants