Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

inexplicit parameter name bug fixed https://github.com/hugegraph/huge… #520

Closed

Conversation

oushu1zhangxiangxuan1
Copy link
Contributor

@oushu1zhangxiangxuan1 oushu1zhangxiangxuan1 commented May 23, 2019

fixed #519

@codecov
Copy link

codecov bot commented May 23, 2019

Codecov Report

Merging #520 into master will decrease coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #520      +/-   ##
============================================
- Coverage     69.37%   69.33%   -0.05%     
  Complexity     3344     3344              
============================================
  Files           216      216              
  Lines         16450    16450              
  Branches       2352     2352              
============================================
- Hits          11413    11405       -8     
- Misses         3776     3785       +9     
+ Partials       1261     1260       -1
Impacted Files Coverage Δ Complexity Δ
...n/java/com/baidu/hugegraph/task/TaskScheduler.java 51.45% <0%> (-1.25%) 26% <0%> (-1%)
...e/src/main/java/com/baidu/hugegraph/HugeGraph.java 70.6% <0%> (-0.96%) 60% <0%> (ø)
...du/hugegraph/backend/tx/GraphIndexTransaction.java 79.36% <0%> (-0.48%) 145% <0%> (ø)
...a/com/baidu/hugegraph/backend/query/Condition.java 62.96% <0%> (+0.52%) 20% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7def830...59c0a01. Read the comment docs.

@javeme
Copy link
Contributor

javeme commented May 23, 2019

@oushu1zhangxiangxuan1 Good improvement, thanks!

Could you update commit message like this:

fixed bug: implicit parameter name 

fixed #519

Note the blank line in the middle and update the pull-request title at the same time.

@javeme
Copy link
Contributor

javeme commented Jun 11, 2019

@oushu1zhangxiangxuan1
Since you haven't updated for a long time, I have already committed it https://github.com/hugegraph/hugegraph/pull/563 for you (you are still the author).

@oushu1zhangxiangxuan1
Copy link
Contributor Author

@javeme oh I'm sorry,I've been busy on my working these days

@javeme
Copy link
Contributor

javeme commented Jun 13, 2019

@oushu1zhangxiangxuan1 It's ok, look forward your further contributions.

ps. @github seems to have a bug, the author has been changed to me after merged, I have already fedback this issue to them.

@javeme javeme closed this Jun 13, 2019
@javeme
Copy link
Contributor

javeme commented Jun 17, 2019

@oushu1zhangxiangxuan1 Regarding the change of author information, Github's response is as follows, apologies for for it.
image

@oushu1zhangxiangxuan1
Copy link
Contributor Author

@javeme It's ok dude. By the way, I'm migrating my Github account to https://github.com/John-Saxon

@oushu1zhangxiangxuan1 Regarding the change of author information, Github's response is as follows, apologies for for it. image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0.9.2 中关于kneighbor和kout 参数max_depth的报错不明确,易混淆
2 participants