Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support paging for scan api #428

Merged
merged 1 commit into from
Apr 2, 2019
Merged

Support paging for scan api #428

merged 1 commit into from
Apr 2, 2019

Conversation

zhoney
Copy link
Contributor

@zhoney zhoney commented Apr 2, 2019

implemented: #360

Change-Id: Idea152b3d53ef519c7ed9847ee9e65092b264e08

@javeme
Copy link
Contributor

javeme commented Apr 2, 2019

please remove “ (#361)” from commit message

implemented: #360

Change-Id: Idea152b3d53ef519c7ed9847ee9e65092b264e08
@zhoney zhoney force-pushed the scan-with-page2 branch from 2b8cf75 to e5bf67d Compare April 2, 2019 09:14
@zhoney zhoney changed the title Support paging for scan api (#361) Support paging for scan api Apr 2, 2019
@zhoney zhoney merged commit c4ca312 into master Apr 2, 2019
@zhoney zhoney deleted the scan-with-page2 branch April 2, 2019 09:39
@codecov
Copy link

codecov bot commented Apr 2, 2019

Codecov Report

Merging #428 into master will decrease coverage by 0.01%.
The diff coverage is 81.81%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #428      +/-   ##
============================================
- Coverage     70.12%   70.11%   -0.02%     
- Complexity     3266     3271       +5     
============================================
  Files           208      208              
  Lines         16042    16050       +8     
  Branches       2297     2301       +4     
============================================
+ Hits          11249    11253       +4     
- Misses         3540     3547       +7     
+ Partials       1253     1250       -3
Impacted Files Coverage Δ Complexity Δ
...ugegraph/backend/cache/CachedGraphTransaction.java 98.36% <100%> (ø) 21 <5> (+1) ⬆️
...aidu/hugegraph/backend/store/hbase/HbaseTable.java 82.85% <80%> (-0.32%) 36 <0> (+2)
.../hugegraph/backend/store/rocksdb/RocksDBTable.java 79.34% <80%> (-0.2%) 33 <0> (+2)
...c/main/java/com/baidu/hugegraph/util/JsonUtil.java 56.6% <0%> (-5.67%) 4% <0%> (-1%)
...c/main/java/com/baidu/hugegraph/task/HugeTask.java 51.96% <0%> (-1.75%) 35% <0%> (-1%)
...e/src/main/java/com/baidu/hugegraph/HugeGraph.java 70.87% <0%> (+0.32%) 60% <0%> (ø) ⬇️
...va/com/baidu/hugegraph/backend/cache/RamCache.java 67.46% <0%> (+0.4%) 42% <0%> (+1%) ⬆️
...a/com/baidu/hugegraph/backend/query/Condition.java 62.96% <0%> (+0.52%) 20% <0%> (ø) ⬇️
...aidu/hugegraph/backend/page/PageEntryIterator.java 82.05% <0%> (+5.12%) 14% <0%> (+1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 582793d...e5bf67d. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants