Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve schema deletion by paging for large data #417

Merged
merged 6 commits into from
Apr 8, 2019

Conversation

zhoney
Copy link
Contributor

@zhoney zhoney commented Mar 28, 2019

implemented: #416

Change-Id: I61f11dfb6367acab9369b53af57c9114a11782c7

@zhoney zhoney changed the title mprove schema deletion by paging for large data Improve schema deletion by paging for large data Mar 28, 2019
@zhoney zhoney force-pushed the schema-delete-with-page branch from 682fc36 to ea35cb1 Compare March 29, 2019 02:17
@codecov
Copy link

codecov bot commented Mar 29, 2019

Codecov Report

Merging #417 into master will decrease coverage by 0.01%.
The diff coverage is 76.05%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #417      +/-   ##
============================================
- Coverage     70.16%   70.15%   -0.02%     
- Complexity     3273     3280       +7     
============================================
  Files           208      208              
  Lines         16054    16081      +27     
  Branches       2301     2310       +9     
============================================
+ Hits          11264    11281      +17     
- Misses         3536     3549      +13     
+ Partials       1254     1251       -3
Impacted Files Coverage Δ Complexity Δ
...com/baidu/hugegraph/backend/page/IdHolderList.java 66.66% <ø> (ø) 9 <0> (ø) ⬇️
...aidu/hugegraph/backend/page/PageEntryIterator.java 83.33% <100%> (+1.28%) 17 <9> (+3) ⬆️
...du/hugegraph/backend/tx/GraphIndexTransaction.java 79.36% <100%> (-0.48%) 145 <0> (ø)
...gegraph/backend/store/scylladb/ScyllaDBTables.java 78.22% <100%> (ø) 13 <0> (ø) ⬇️
...n/java/com/baidu/hugegraph/config/CoreOptions.java 98.59% <100%> (ø) 2 <0> (ø) ⬇️
...m/baidu/hugegraph/backend/tx/GraphTransaction.java 82.12% <53.33%> (-0.8%) 208 <2> (+1)
.../java/com/baidu/hugegraph/backend/query/Query.java 69.91% <83.33%> (+1.39%) 49 <3> (+3) ⬆️
.../hugegraph/backend/store/BackendEntryIterator.java 66.66% <83.33%> (+2.08%) 14 <0> (ø) ⬇️
...va/com/baidu/hugegraph/backend/page/QueryList.java 78.78% <90.9%> (-3.32%) 16 <2> (-1)
...ain/java/com/baidu/hugegraph/task/TaskManager.java 60.86% <0%> (-4.35%) 10% <0%> (-1%)
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 768b24f...2fa55f5. Read the comment docs.

@zhoney zhoney force-pushed the schema-delete-with-page branch 3 times, most recently from ac5f481 to a2e5f0f Compare March 31, 2019 06:42
@zhoney zhoney force-pushed the schema-delete-with-page branch 2 times, most recently from 496564e to 1c52dd1 Compare April 1, 2019 11:43
@zhoney zhoney force-pushed the schema-delete-with-page branch from 1c52dd1 to 286cba7 Compare April 1, 2019 11:55
@zhoney zhoney force-pushed the schema-delete-with-page branch from 286cba7 to b9a3b47 Compare April 1, 2019 12:09
@zhoney zhoney force-pushed the schema-delete-with-page branch from fbe185d to beb36ce Compare April 2, 2019 10:31
zhoney added 6 commits April 3, 2019 10:53
implemented: #416

Change-Id: I61f11dfb6367acab9369b53af57c9114a11782c7
Change-Id: Ifca1ab84a66778cea0669c971a0440e8b1c9d674
Change-Id: I0687cab77284895d8e803a74cd3f30b0df0a004b
Change-Id: I265f6f226dfe19f6ab66d5eaae6d5f969f591949
Change-Id: I0284b6ea7edd33898c54b5bf223ab069a229245d
Change-Id: I4a4a13c42ef71f9f73544793c1e11503d37b21ff
@zhoney zhoney force-pushed the schema-delete-with-page branch from beb36ce to 2fa55f5 Compare April 3, 2019 03:00
@javeme javeme merged commit 490b0cd into master Apr 8, 2019
@javeme javeme deleted the schema-delete-with-page branch April 8, 2019 03:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants