Add personalrank and neighborrank RESTful API #274

Linary · 2018-12-10T10:37:15Z

Change-Id: Ifc65c488aac51111551e78bf3deb5790c5e83491

hugegraph-api/src/main/java/com/baidu/hugegraph/api/traversers/NeighborRankAPI.java

zhoney · 2018-12-13T08:37:32Z

hugegraph-api/src/main/java/com/baidu/hugegraph/api/traversers/NeighborRankAPI.java

+        }
+        // The rank of each seed vertex is attenuated to original * (1 - alpha)
+        for (Object vertexId : seedVertices) {
+            double oldRank = rank.get(vertexId) * (1 - alpha);


will incorrect if have loop

hugegraph-api/src/main/java/com/baidu/hugegraph/api/traversers/PersonalRankAPI.java

zhoney · 2018-12-13T08:46:54Z

hugegraph-api/src/main/java/com/baidu/hugegraph/api/traversers/PersonalRankAPI.java

+        consumer.accept(tmpSeeds);
+
+        double sourceRank = tmpRank.get(sourceV);
+        sourceRank += (1 - alpha);


https://blog.csdn.net/bbbeoy/article/details/78646635

source vertex need add (1 - alpha) every time

hugegraph-api/src/main/java/com/baidu/hugegraph/api/traversers/NeighborRankAPI.java

hugegraph-core/src/main/java/com/baidu/hugegraph/traversal/optimize/HugeTraverser.java

javeme · 2018-12-17T06:54:03Z

hugegraph-core/src/main/java/com/baidu/hugegraph/traversal/algorithm/RankAlgorithm.java

+        while (++depth <= this.maxDepth) {
+            Map<Id, Double> rankIncrs = this.getRankIncrs(seeds, labelDirs,
+                    labelId, ranks);
+            this.combineIncrement(seeds, ranks, rankIncrs);


ranks = this.combineIncrement()

javeme · 2018-12-17T06:59:13Z

hugegraph-core/src/main/java/com/baidu/hugegraph/traversal/algorithm/RankAlgorithm.java

+                                         Map<Id, Double> ranks) {
+        Map<Id, Double> rankIncrs = new HashMap<>();
+        for (Id seed : seeds) {
+            Vertex vertex = this.graph().vertices(seed).next();


will reduce the performance

hugegraph-core/src/main/java/com/baidu/hugegraph/traversal/algorithm/RankAlgorithm.java

already edited

hugegraph-core/src/main/java/com/baidu/hugegraph/traversal/algorithm/RankAlgorithm.java

codecov · 2019-04-03T06:50:29Z

Codecov Report

Merging #274 into master will decrease coverage by 0.03%.
The diff coverage is 100%.

@@             Coverage Diff             @@
##             master    #274      +/-   ##
===========================================
- Coverage     68.94%   68.9%   -0.04%     
  Complexity     3278    3278              
===========================================
  Files           208     208              
  Lines         16171   16170       -1     
  Branches       2327    2327              
===========================================
- Hits          11149   11142       -7     
- Misses         3777    3783       +6     
  Partials       1245    1245

Impacted Files	Coverage Δ	Complexity Δ
...m/baidu/hugegraph/backend/query/IdPrefixQuery.java	`62.96% <100%> (+1.42%)`	`8 <0> (ø)`	⬇️
.../java/com/baidu/hugegraph/version/CoreVersion.java	`80% <100%> (ø)`	`2 <1> (ø)`	⬇️
.../java/com/baidu/hugegraph/backend/query/Query.java	`71.66% <100%> (+1.75%)`	`50 <1> (+1)`	⬆️
...om/baidu/hugegraph/backend/query/IdRangeQuery.java	`60% <100%> (+1.66%)`	`7 <0> (ø)`	⬇️
...hugegraph/backend/serializer/BinarySerializer.java	`80.1% <100%> (-0.33%)`	`102 <0> (ø)`
...n/java/com/baidu/hugegraph/task/TaskScheduler.java	`51.45% <0%> (-1.25%)`	`26% <0%> (-1%)`
...du/hugegraph/backend/tx/GraphIndexTransaction.java	`79.36% <0%> (-0.48%)`	`145% <0%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cf80faf...6b2ab28. Read the comment docs.

hugegraph-core/src/main/java/com/baidu/hugegraph/traversal/algorithm/HugeTraverser.java

hugegraph-api/src/main/java/com/baidu/hugegraph/api/traversers/NeighborRankAPI.java

hugegraph-example/src/main/java/com/baidu/hugegraph/example/Example2.java

hugegraph-example/src/main/resources/hugegraph.properties

hugegraph-api/src/main/java/com/baidu/hugegraph/api/traversers/PersonalRankAPI.java

hugegraph-core/src/main/java/com/baidu/hugegraph/traversal/algorithm/RankAlgorithm.java

hugegraph-api/src/main/java/com/baidu/hugegraph/api/traversers/NeighborRankAPI.java

hugegraph-core/src/main/java/com/baidu/hugegraph/traversal/algorithm/HugeTraverser.java

hugegraph-core/src/main/java/com/baidu/hugegraph/traversal/algorithm/RankTraverser.java

hugegraph-api/src/main/java/com/baidu/hugegraph/api/traversers/NeighborRankAPI.java

hugegraph-example/src/main/java/com/baidu/hugegraph/example/ValueComparableMap.java

hugegraph-core/src/main/java/com/baidu/hugegraph/traversal/algorithm/RankTraverser.java

javeme · 2019-04-15T07:56:08Z

hugegraph-core/src/main/java/com/baidu/hugegraph/traversal/algorithm/RankTraverser.java

+        } else if (o1 < o2) {
+            return 1;
+        } else {
+            return 0;


will it delete duplicated values?

hugegraph-core/src/main/java/com/baidu/hugegraph/traversal/algorithm/RankTraverser.java

hugegraph-core/src/main/java/com/baidu/hugegraph/util/OrderLimitMap.java

hugegraph-test/src/main/java/com/baidu/hugegraph/unit/core/OrderLimitMapTest.java

hugegraph-api/src/main/java/com/baidu/hugegraph/api/traversers/NeighborRankAPI.java

hugegraph-core/src/main/java/com/baidu/hugegraph/traversal/algorithm/RankTraverser.java

Change-Id: I66e4224b5813aa2d5eadbfe540fb9de203db766b

Change-Id: I8cb701940a323883796c6cbc60dd8b17d4f6ba88

hugegraph-core/src/main/java/com/baidu/hugegraph/traversal/algorithm/RankTraverser.java

hugegraph-api/src/main/java/com/baidu/hugegraph/api/traversers/NeighborRankAPI.java

Change-Id: I8f02506cbc3acfa62072f46e4f2000e5edd8502c

Change-Id: Ib66fce20642e89b49a7bf45edb223ab4bd5c27dd

hugegraph-api/src/main/java/com/baidu/hugegraph/api/traversers/PersonalRankAPI.java

hugegraph-core/src/main/java/com/baidu/hugegraph/traversal/algorithm/PersonalRankTraverser.java

Change-Id: I79b2d6ae1f780728cc935c147ca8d96f3a786bf8

hugegraph-core/src/main/java/com/baidu/hugegraph/traversal/algorithm/NeighborRankTraverser.java

Change-Id: I5012e7e7be649ccf7c7de160354a39b980fecf48

hugegraph-api/src/main/java/com/baidu/hugegraph/api/traversers/PersonalRankAPI.java

hugegraph-api/src/main/java/com/baidu/hugegraph/api/traversers/NeighborRankAPI.java

hugegraph-example/src/main/java/com/baidu/hugegraph/example/Example3.java

hugegraph-test/src/main/java/com/baidu/hugegraph/unit/UnitTestSuite.java

hugegraph-core/src/main/java/com/baidu/hugegraph/traversal/algorithm/NeighborRankTraverser.java

Change-Id: I8c27b23216bd9ee97c2afa613890a6a23b66df5d

hugegraph-api/src/main/java/com/baidu/hugegraph/api/traversers/PersonalRankAPI.java

hugegraph-core/src/main/java/com/baidu/hugegraph/traversal/algorithm/NeighborRankTraverser.java

Change-Id: I2bd0d75f0a798015ea302679cdf2635b7fc80745

hugegraph-core/src/main/java/com/baidu/hugegraph/traversal/algorithm/NeighborRankTraverser.java

Change-Id: I4ae50946c46a016872848dbcd9f69e70b6f290a2

Change-Id: I9829eacea9e8598a4475b39bd9699ea951de6a97

hugegraph-core/src/main/java/com/baidu/hugegraph/traversal/algorithm/NeighborRankTraverser.java

hugegraph-core/src/main/java/com/baidu/hugegraph/traversal/algorithm/PersonalRankTraverser.java

Change-Id: Ib8c2da1f85c9e78504d704b0b3629a24b0666e42

javeme

remove @Status(Status.CREATED) for CustomizedPathsAPI and CustomizedCrosspointsAPI

Change-Id: Iccda41b7869a53a77177d342754f080f6e4612e4

hugegraph-api/src/main/java/com/baidu/hugegraph/api/traversers/PersonalRankAPI.java

hugegraph-core/src/main/java/com/baidu/hugegraph/traversal/algorithm/NeighborRankTraverser.java

hugegraph-api/src/main/java/com/baidu/hugegraph/api/traversers/NeighborRankAPI.java

Change-Id: I9cb451b4612ff540da9e1045a44970e119d35d6e

Linary force-pushed the neighbor-rank branch 3 times, most recently from b376b2f to 3ec773d Compare December 12, 2018 01:52

zhoney requested changes Dec 13, 2018

View reviewed changes

javeme requested changes Dec 14, 2018

View reviewed changes

hugegraph-api/src/main/java/com/baidu/hugegraph/api/traversers/NeighborRankAPI.java Outdated Show resolved Hide resolved

hugegraph-api/src/main/java/com/baidu/hugegraph/api/traversers/NeighborRankAPI.java Outdated Show resolved Hide resolved

Linary force-pushed the neighbor-rank branch from 3ec773d to c84cab6 Compare December 14, 2018 12:52

javeme previously requested changes Dec 17, 2018

View reviewed changes

Linary force-pushed the neighbor-rank branch from c84cab6 to eece519 Compare December 18, 2018 02:18

javeme requested changes Dec 24, 2018

View reviewed changes

hugegraph-core/src/main/java/com/baidu/hugegraph/traversal/algorithm/RankAlgorithm.java Outdated Show resolved Hide resolved

hugegraph-core/src/main/java/com/baidu/hugegraph/traversal/algorithm/RankAlgorithm.java Outdated Show resolved Hide resolved

Linary force-pushed the neighbor-rank branch from eece519 to c9948ce Compare April 3, 2019 06:35

javeme requested changes Apr 3, 2019

View reviewed changes

Linary force-pushed the neighbor-rank branch from 9b9afeb to 08ba71b Compare April 3, 2019 08:58

javeme requested changes Apr 3, 2019

View reviewed changes

hugegraph-api/src/main/java/com/baidu/hugegraph/api/traversers/NeighborRankAPI.java Outdated Show resolved Hide resolved

hugegraph-core/src/main/java/com/baidu/hugegraph/traversal/algorithm/HugeTraverser.java Outdated Show resolved Hide resolved

Linary force-pushed the neighbor-rank branch 5 times, most recently from d9998a5 to 5936537 Compare April 10, 2019 12:14

javeme requested changes Apr 12, 2019

View reviewed changes

javeme requested changes Apr 15, 2019

View reviewed changes

Add PersonalrRank and NeighborRank RESTful API

eef7f2f

Change-Id: I66e4224b5813aa2d5eadbfe540fb9de203db766b

Linary force-pushed the neighbor-rank branch from 93e0806 to eef7f2f Compare April 16, 2019 03:42

Code optimization

de15f53

Change-Id: I8cb701940a323883796c6cbc60dd8b17d4f6ba88

javeme requested changes Apr 16, 2019

View reviewed changes

zhoney requested changes Apr 16, 2019

View reviewed changes

Linary added 2 commits April 16, 2019 15:38

Encapsulate some methods

19c49c8

Change-Id: I8f02506cbc3acfa62072f46e4f2000e5edd8502c

tiny improve

2a95cbe

Change-Id: Ib66fce20642e89b49a7bf45edb223ab4bd5c27dd

javeme requested changes Apr 16, 2019

View reviewed changes

Add dependency hugegraph-common 1.6.0

da7be43

Change-Id: I79b2d6ae1f780728cc935c147ca8d96f3a786bf8

javeme requested changes Apr 16, 2019

View reviewed changes

hugegraph-core/src/main/java/com/baidu/hugegraph/traversal/algorithm/NeighborRankTraverser.java Show resolved Hide resolved

hugegraph-core/src/main/java/com/baidu/hugegraph/traversal/algorithm/NeighborRankTraverser.java Outdated Show resolved Hide resolved

tiny improve

7146434

Change-Id: I5012e7e7be649ccf7c7de160354a39b980fecf48

zhoney requested changes Apr 16, 2019

View reviewed changes

hugegraph-core/src/main/java/com/baidu/hugegraph/traversal/algorithm/NeighborRankTraverser.java Outdated Show resolved Hide resolved

fix some bugs

fa1a427

Change-Id: I8c27b23216bd9ee97c2afa613890a6a23b66df5d

javeme requested changes Apr 17, 2019

View reviewed changes

Refactor class Adjacencies

f8f817d

Change-Id: I2bd0d75f0a798015ea302679cdf2635b7fc80745

javeme requested changes Apr 17, 2019

View reviewed changes

hugegraph-core/src/main/java/com/baidu/hugegraph/traversal/algorithm/NeighborRankTraverser.java Show resolved Hide resolved

hugegraph-core/src/main/java/com/baidu/hugegraph/traversal/algorithm/NeighborRankTraverser.java Show resolved Hide resolved

tiny improve

37ffcfd

Change-Id: I4ae50946c46a016872848dbcd9f69e70b6f290a2

Linary force-pushed the neighbor-rank branch from 0a2414c to 37ffcfd Compare April 17, 2019 08:19

fix degree limit lost

66af119

Change-Id: I9829eacea9e8598a4475b39bd9699ea951de6a97

zhoney requested changes Apr 17, 2019

View reviewed changes

Linary force-pushed the neighbor-rank branch 2 times, most recently from 23add91 to 44e2712 Compare April 18, 2019 03:44

tiny improve

0f6df0f

Change-Id: Ib8c2da1f85c9e78504d704b0b3629a24b0666e42

Linary force-pushed the neighbor-rank branch from 44e2712 to 0f6df0f Compare April 18, 2019 10:17

javeme approved these changes Apr 18, 2019

View reviewed changes

javeme requested changes Apr 18, 2019

View reviewed changes

remove status created annotation

c498f56

Change-Id: Iccda41b7869a53a77177d342754f080f6e4612e4

javeme previously approved these changes Apr 18, 2019

View reviewed changes

zhoney requested changes Apr 18, 2019

View reviewed changes

use HugeVertex.getIdValue

6b2ab28

Change-Id: I9cb451b4612ff540da9e1045a44970e119d35d6e

Linary dismissed javeme’s stale review via 6b2ab28 April 18, 2019 14:30

zhoney approved these changes Apr 19, 2019

View reviewed changes

javeme approved these changes Apr 19, 2019

View reviewed changes

javeme merged commit 2890c96 into master Apr 19, 2019

javeme deleted the neighbor-rank branch April 19, 2019 03:14

Linary mentioned this pull request Apr 22, 2019

Add personalrank and neighborrank RESTful API #273

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add personalrank and neighborrank RESTful API #274

Add personalrank and neighborrank RESTful API #274

Linary commented Dec 10, 2018

zhoney Dec 13, 2018

zhoney Dec 13, 2018

Linary Dec 14, 2018

javeme Dec 17, 2018

javeme Dec 17, 2018

codecov bot commented Apr 3, 2019 •

edited

Loading

javeme Apr 15, 2019

Linary Apr 15, 2019

javeme left a comment

Add personalrank and neighborrank RESTful API #274

Add personalrank and neighborrank RESTful API #274

Conversation

Linary commented Dec 10, 2018

zhoney Dec 13, 2018

Choose a reason for hiding this comment

zhoney Dec 13, 2018

Choose a reason for hiding this comment

Linary Dec 14, 2018

Choose a reason for hiding this comment

javeme Dec 17, 2018

Choose a reason for hiding this comment

javeme Dec 17, 2018

Choose a reason for hiding this comment

codecov bot commented Apr 3, 2019 • edited Loading

Codecov Report

javeme Apr 15, 2019

Choose a reason for hiding this comment

Linary Apr 15, 2019

Choose a reason for hiding this comment

javeme left a comment

Choose a reason for hiding this comment

codecov bot commented Apr 3, 2019 •

edited

Loading