-
Notifications
You must be signed in to change notification settings - Fork 522
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(server): mark old raft configs as deprecated #2661
Merged
imbajin
merged 2 commits into
apache:master
from
shirleyStorage:deprecated_old_raft_config
Sep 8, 2024
Merged
chore(server): mark old raft configs as deprecated #2661
imbajin
merged 2 commits into
apache:master
from
shirleyStorage:deprecated_old_raft_config
Sep 8, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: shirley <shirley.d.storage@gmail.com>
dosubot
bot
added
size:M
This PR changes 30-99 lines, ignoring generated files.
raft
labels
Sep 4, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2661 +/- ##
============================================
- Coverage 47.60% 38.42% -9.19%
+ Complexity 820 632 -188
============================================
Files 718 718
Lines 58469 58469
Branches 7496 7496
============================================
- Hits 27835 22467 -5368
- Misses 27854 33596 +5742
+ Partials 2780 2406 -374 ☔ View full report in Codecov by Sentry. |
imbajin
reviewed
Sep 6, 2024
hugegraph-server/hugegraph-dist/src/assembly/static/conf/graphs/hstore.properties.template
Outdated
Show resolved
Hide resolved
imbajin
reviewed
Sep 6, 2024
hugegraph-server/hugegraph-dist/src/assembly/static/conf/graphs/hstore.properties.template
Outdated
Show resolved
Hide resolved
imbajin
reviewed
Sep 6, 2024
hugegraph-server/hugegraph-dist/src/assembly/static/conf/graphs/hugegraph.properties
Outdated
Show resolved
Hide resolved
imbajin
changed the title
Note the old raft config will be deprecated
chore(server): mark old raft configs as deprecated
Sep 6, 2024
Signed-off-by: shirley <shirley.d.storage@gmail.com>
VGalaxies
approved these changes
Sep 8, 2024
imbajin
approved these changes
Sep 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of the PR
Main Changes
Place the raft configurations at the bottom of the properties file and mark it as being deprecated.
Verifying these changes
Does this PR potentially affect the following parts?
Documentation Status
Doc - TODO
Doc - Done
Doc - No Need