Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(server): support in-heap memory JVM monitor #2650

Merged
merged 8 commits into from
Oct 15, 2024

Conversation

MingzhenHan
Copy link
Contributor

@MingzhenHan MingzhenHan commented Aug 27, 2024

Short Desc (Feature)

In order to avoid OOM errors caused by large queries, an jvm in heap memory monitoring mechanism was introduced in Hugegraph Server, which monitors the JVM's memory usage through scheduled tasks. If the threshold is exceeded, trigger GC or set interrupt flag to the corresponding thread to avoid OOM.

Related config PR: apache/incubator-hugegraph-doc#376

Details Docs

For more details, please visit the link:

@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. feature New feature labels Aug 27, 2024
@MingzhenHan MingzhenHan marked this pull request as draft August 27, 2024 11:51
@MingzhenHan MingzhenHan marked this pull request as ready for review August 27, 2024 14:04
@imbajin imbajin requested review from javeme and zyxxoo August 28, 2024 04:36
@imbajin imbajin changed the title feat(server): Add jvm memory monitor feature feat(server): support in-heap memory JVM monitor Aug 28, 2024
Copy link

codecov bot commented Oct 5, 2024

Codecov Report

Attention: Patch coverage is 38.46154% with 40 lines in your changes missing coverage. Please review.

Project coverage is 38.40%. Comparing base (355483f) to head (2fee36f).
Report is 8 commits behind head on master.

Files with missing lines Patch % Lines
.../java/org/apache/hugegraph/dist/MemoryMonitor.java 30.90% 36 Missing and 2 partials ⚠️
.../hugegraph/backend/store/BackendEntryIterator.java 0.00% 1 Missing ⚠️
...ava/org/apache/hugegraph/dist/HugeGraphServer.java 66.66% 1 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (355483f) and HEAD (2fee36f). Click for more details.

HEAD has 5 uploads less than BASE
Flag BASE (355483f) HEAD (2fee36f)
7 2
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #2650      +/-   ##
============================================
- Coverage     47.66%   38.40%   -9.26%     
+ Complexity      822      515     -307     
============================================
  Files           718      731      +13     
  Lines         58469    60132    +1663     
  Branches       7496     7802     +306     
============================================
- Hits          27868    23093    -4775     
- Misses        27814    34543    +6729     
+ Partials       2787     2496     -291     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Oct 15, 2024
@VGalaxies VGalaxies merged commit 0cb6115 into apache:master Oct 15, 2024
17 checks passed
imbajin pushed a commit to apache/incubator-hugegraph-doc that referenced this pull request Nov 1, 2024
github-actions bot pushed a commit to apache/incubator-hugegraph-doc that referenced this pull request Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

6 participants