Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pd):PartitionCache lockGraph Logic error #2640

Merged
merged 2 commits into from
Sep 24, 2024

Conversation

haohao0103
Copy link
Contributor

close #2639

@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. pd PD module labels Aug 14, 2024
Copy link

codecov bot commented Aug 14, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 35.05%. Comparing base (a038d23) to head (6148c6f).
Report is 233 commits behind head on master.

Files with missing lines Patch % Lines
...org/apache/hugegraph/pd/common/PartitionCache.java 0.00% 1 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (a038d23) and HEAD (6148c6f). Click for more details.

HEAD has 4 uploads less than BASE
Flag BASE (a038d23) HEAD (6148c6f)
5 1
Additional details and impacted files
@@              Coverage Diff              @@
##             master    #2640       +/-   ##
=============================================
- Coverage     45.17%   35.05%   -10.13%     
+ Complexity      583      382      -201     
=============================================
  Files           718      719        +1     
  Lines         58434    58465       +31     
  Branches       7491     7495        +4     
=============================================
- Hits          26396    20492     -5904     
- Misses        29318    35754     +6436     
+ Partials       2720     2219      -501     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@VGalaxies VGalaxies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch~

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Aug 17, 2024
@VGalaxies VGalaxies requested a review from imbajin August 17, 2024 10:59
Copy link

Due to the lack of activity, the current pr is marked as stale and will be closed after 180 days, any update will remove the stale label

@imbajin imbajin merged commit d2906a6 into apache:master Sep 24, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
inactive lgtm This PR has been approved by a maintainer pd PD module size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[Bug] PD PartitionCache lockGraph method opposite to the expected behavior.
3 participants