chore(store): translate CJK comments to English for store-dist, store-grpc, store-node, store-rocksdb, store-test #2624
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VGalaxies
commented
Aug 6, 2024
...store/hg-store-test/src/main/java/org/apache/hugegraph/store/HgSessionManagerRaftPDTest.java
Outdated
Show resolved
Hide resolved
...graph-store/hg-store-test/src/main/java/org/apache/hugegraph/store/HgSessionManagerTest.java
Outdated
Show resolved
Hide resolved
hugegraph-store/hg-store-test/src/main/java/org/apache/hugegraph/store/PartitionEngineTest.java
Outdated
Show resolved
Hide resolved
...g-store-test/src/main/java/org/apache/hugegraph/store/client/HgSessionManagerRaftPDTest.java
Outdated
Show resolved
Hide resolved
40 tasks
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2624 +/- ##
============================================
- Coverage 48.39% 47.23% -1.17%
+ Complexity 746 583 -163
============================================
Files 719 719
Lines 58471 58471
Branches 7496 7496
============================================
- Hits 28299 27619 -680
- Misses 27334 28064 +730
+ Partials 2838 2788 -50 ☔ View full report in Codecov by Sentry. |
dosubot
bot
added
size:L
Pengzna
approved these changes
Aug 6, 2024
hugegraph-store/hg-store-dist/src/assembly/static/conf/application-pd.yml
Outdated
Show resolved
Hide resolved
hugegraph-store/hg-store-dist/src/assembly/static/conf/application-pd.yml
Outdated
Show resolved
Hide resolved
Co-authored-by: Peng Junzhi <[email protected]>
imbajin
previously approved these changes
Aug 10, 2024
JackyYangPassion
requested changes
Aug 10, 2024
...store/hg-store-rocksdb/src/main/java/org/apache/hugegraph/rocksdb/access/RocksDBFactory.java
Outdated
Show resolved
Hide resolved
javeme
requested changes
Aug 10, 2024
.asf.yaml
Outdated
| @@ -28,7 +28,7 @@ github: | |||
| del_branch_on_merge: true | |||
| #labels: | |||
| enabled_merge_buttons: | |||
| merge: false | |||
| merge: true | |||
There was a problem hiding this comment.
Prefer to disable merge button.
In order to keep a clear history, we do not expect to introduce merge commits.
There was a problem hiding this comment.
get it
@javeme need your approve to merge this PR 🔢
imbajin
previously approved these changes
Aug 10, 2024
JackyYangPassion
previously approved these changes
Aug 10, 2024
VGalaxies
dismissed stale reviews from JackyYangPassion and imbajin
via
fb9144c
This reverts commit 9ebdb3e.
imbajin
previously approved these changes
Aug 13, 2024
imbajin
previously approved these changes
Aug 18, 2024
|
@javeme need your approval to merge this PR 😶🌫️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
subtask of #2575
Except for some Chinese character tests in https://github.com/apache/incubator-hugegraph/blob/master/hugegraph-store/hg-store-test/src/main/java/org/apache/hugegraph/store/util/UnsafeUtilTest.java.