fix(hstore): JRaft Metrics miss #2604
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
size:M
shirleyStorage
approved these changes
Jul 29, 2024
|
LGTM~. |
javeme
reviewed
Aug 10, 2024
...re/hg-store-node/src/main/java/org/apache/hugegraph/store/node/metrics/MetricsRefresher.java
Outdated
Show resolved
Hide resolved
| @@ -65,10 +65,18 @@ public class JRaftMetrics { | |||
| private JRaftMetrics() { | |||
| } | |||
|
|
|||
| public synchronized static void init(MeterRegistry meterRegistry) { | |||
| public synchronized static void init(MeterRegistry meterRegistry, boolean isInitialCall) { | |||
| if (registry == null) { | |||
There was a problem hiding this comment.
can we refactor to this style JRaftMetrics.instance(registry)
| @@ -65,10 +65,18 @@ public class JRaftMetrics { | |||
| private JRaftMetrics() { | |||
| } | |||
|
|
|||
| public synchronized static void init(MeterRegistry meterRegistry) { | |||
| public synchronized static void init(MeterRegistry meterRegistry, boolean isInitialCall) { | |||
There was a problem hiding this comment.
isInitialCall -- Is there an elegant way to avoid this a bit complex branching?
|
Due to the lack of activity, the current pr is marked as stale and will be closed after 180 days, any update will remove the stale label |
javeme
reviewed
Oct 27, 2024
| log.debug("JRaftMetrics initialized during scheduled refresh"); | ||
| } | ||
| } else if (!isInitialCall) { | ||
| registerNodeMetrics(); |
There was a problem hiding this comment.
prefer to add a new method like resetNodeMetrics() instead of adding a isInitialCall param
There was a problem hiding this comment.
Thanks for your suggestion, I will optimize it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of the PR
Main Changes
Verifying these changes
Does this PR potentially affect the following parts?
Documentation Status
Doc - TODODoc - DoneDoc - No Need