Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(hstore): JRaft Timer Metrics BUG #2602

Merged
merged 4 commits into from
Aug 2, 2024
Merged

fix(hstore): JRaft Timer Metrics BUG #2602

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
434c0f2
fix JRaft Timer Metrics BUG
JackyYangPassion Jul 29, 2024
5aec8dd
Merge branch 'master' into fix-2601
VGalaxies Aug 2, 2024
8170379
Merge branch 'master' into fix-2601
imbajin Aug 2, 2024
d6b3b0f
Merge branch 'master' into fix-2601
imbajin Aug 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 29 additions & 11 deletions ...ore/hg-store-node/src/main/java/org/apache/hugegraph/store/node/metrics/JRaftMetrics.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -214,18 +214,36 @@ private static void registerTimer(String group, String name, com.codahale.metric

String baseName = PREFIX + "." + name.toLowerCase();

Gauge.builder(baseName + ".count", timer, Timer::getCount)
Gauge.builder(baseName + ".count", timer, t->t.getCount())
.tags(tags).register(registry);
Gauge.builder(baseName + ".min", timer, t -> t.getSnapshot().getMin())
.tags(tags).register(registry);
Gauge.builder(baseName + ".max", timer, t -> t.getSnapshot().getMax())
.tags(tags).register(registry);
Gauge.builder(baseName + ".mean", timer, t -> t.getSnapshot().getMean())
.tags(tags).register(registry);
Gauge.builder(baseName + ".stddev", timer, t -> t.getSnapshot().getStdDev())
.tags(tags).register(registry);
Gauge.builder(baseName + ".p50", timer, t -> t.getSnapshot().getMedian())
.tags(tags).register(registry);
Gauge.builder(baseName + ".p75", timer, t -> t.getSnapshot().get75thPercentile())
.tags(tags).register(registry);
Gauge.builder(baseName + ".p95", timer, t -> t.getSnapshot().get95thPercentile())
.tags(tags).register(registry);
Gauge.builder(baseName + ".p98", timer, t -> t.getSnapshot().get98thPercentile())
.tags(tags).register(registry);
Gauge.builder(baseName + ".p99", timer, t -> t.getSnapshot().get99thPercentile())
.tags(tags).register(registry);
Gauge.builder(baseName + ".p999", timer, t -> t.getSnapshot().get999thPercentile())
.tags(tags).register(registry);
Gauge.builder(baseName + ".m1_rate", timer, t -> t.getOneMinuteRate())
.tags(tags).register(registry);
Gauge.builder(baseName + ".m5_rate", timer, t -> t.getFiveMinuteRate())
.tags(tags).register(registry);
Gauge.builder(baseName + ".m15_rate", timer, t -> t.getFifteenMinuteRate())
.tags(tags).register(registry);
Gauge.builder(baseName + ".mean_rate", timer, t -> t.getMeanRate())
.tags(tags).register(registry);

Gauge.builder(baseName + ".timer", timer, Timer::getCount)
.tags(tags).tag("rate", "1m").register(registry);
Gauge.builder(baseName + ".timer", timer, Timer::getCount)
.tags(tags).tag("rate", "5m").register(registry);
Gauge.builder(baseName + ".timer", timer, Timer::getCount)
.tags(tags).tag("rate", "15m").register(registry);
Gauge.builder(baseName + ".timer", timer, Timer::getCount)
.tags(tags).tag("rate", "mean").register(registry);

}

private static void registerMeter(String group, String name, com.codahale.metrics.Meter meter) {
Expand Down
Loading