Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pd/store): log files do not scroll with the process #2589

Merged
merged 6 commits into from
Aug 2, 2024

Conversation

haohao0103
Copy link
Contributor

close #2581

GRPC Java defaults to using java. til.rogging (JUL) as its logging framework,

GRPC Java defaults to using java. til.logging (JUL) as the logging framework. In order to print logs using log4j2.xml configuration rules, the dependency Bridge from JUL to Log4j is used
@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. pd PD module store Store module labels Jul 15, 2024
@imbajin imbajin changed the title PD, Store process log files do not scrollclose #2581 fix(pd/store): log files do not scroll with the process Jul 15, 2024
@imbajin imbajin requested a review from VGalaxies July 16, 2024 08:30
@@ -129,7 +129,7 @@
<!-- Use mixed async way to output logs -->
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comments here are somewhat outdated. I found that AsyncLogger is still being used in hugegraph-pd/hg-pd-service/src/main/resources/log4j2.xml. Any context @imbajin?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comments here are somewhat outdated. I found that AsyncLogger is still being used in hugegraph-pd/hg-pd-service/src/main/resources/log4j2.xml. Any context @imbajin?

maybe just due to (they) copy the config file from server?

@VGalaxies
Copy link
Contributor

@haohao0103 Running the start-hugegraph-pd.sh script reports an error?

 Error: Could not find or load main class .logging.log4j.jul.LogManager                                                                                                                                                                      
 Caused by: java.lang.ClassNotFoundException: /logging/log4j/jul/LogManager                                                                                                                                                                  

@haohao0103
Copy link
Contributor Author

haohao0103 commented Jul 22, 2024

@haohao0103 Running the start-hugegraph-pd.sh script reports an error?

 Error: Could not find or load main class .logging.log4j.jul.LogManager                                                                                                                                                                      
 Caused by: java.lang.ClassNotFoundException: /logging/log4j/jul/LogManager                                                                                                                                                                  

exec ${JAVA} -Dname="HugeGraphPD" ${JVM_OPTIONS} ${JAVA_OPTIONS} -jar
-Dspring.config.location=${CONF}/application.yml ${LIB}/hg-pd-service-*.jar >> ${OUTPUT} 2>&1 &

According to this startup command, there needs to be hg-pd-service - *. jar in the lib directory. I guess the target dependency was not generated?

@VGalaxies
Copy link
Contributor

@haohao0103 Running the start-hugegraph-pd.sh script reports an error?

 Error: Could not find or load main class .logging.log4j.jul.LogManager                                                                                                                                                                      
 Caused by: java.lang.ClassNotFoundException: /logging/log4j/jul/LogManager                                                                                                                                                                  

exec ${JAVA} -Dname="HugeGraphPD" ${JVM_OPTIONS} ${JAVA_OPTIONS} -jar -Dspring.config.location=${CONF}/application.yml ${LIB}/hg-pd-service-*.jar >> ${OUTPUT} 2>&1 &

According to this startup command, there needs to be hg-pd-service - *. jar in the lib directory. I guess the target dependency was not generated?

I discovered an unexpected line break...

623ce53 (#2589)

@VGalaxies
Copy link
Contributor

merge it after #2599

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jul 31, 2024
@imbajin imbajin merged commit 24ebe9d into apache:master Aug 2, 2024
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer pd PD module size:S This PR changes 10-29 lines, ignoring generated files. store Store module
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[Bug] PD, Store process log files do not scroll
4 participants