Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#2576 Resolve the cache invalidation of the partition->leader shard in ClientCache #2577

Closed
wants to merge 1 commit into from

Conversation

haohao0103
Copy link
Contributor

Resolved the cache invalidation of the partition->leader shard in ClientCache

Purpose of the PR

close #2576

Main Changes

1、Set the initialization flag to false after resetting the cache, allowing reinitialization;
2、If the cache misses, the cache is updated with the results of the query from the PD.

Resolved the cache invalidation of the partition->leader shard in ClientCache
@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. pd PD module labels Jul 12, 2024
Copy link

codecov bot commented Jul 12, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Please upload report for BASE (pd-store@e1bd708). Learn more about missing BASE report.

Files Patch % Lines
.../java/org/apache/hugegraph/pd/client/PDClient.java 0.00% 2 Missing ⚠️
...va/org/apache/hugegraph/pd/client/ClientCache.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             pd-store    #2577   +/-   ##
===========================================
  Coverage            ?   36.14%           
  Complexity          ?      635           
===========================================
  Files               ?      717           
  Lines               ?    58368           
  Branches            ?     7489           
===========================================
  Hits                ?    21098           
  Misses              ?    34974           
  Partials            ?     2296           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@VGalaxies
Copy link
Contributor

@haohao0103 could consider directly submitting a PR to master branch, most of the diffs from the pd-store branch has already been merged into the master branch

@VGalaxies VGalaxies requested a review from imbajin July 12, 2024 10:23
@haohao0103
Copy link
Contributor Author

@haohao0103 could consider directly submitting a PR to master branch, most of the diffs from the pd-store branch has already been merged into the master branch

OK

@haohao0103 haohao0103 closed this Jul 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pd PD module size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants