Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(server): random generate default value #2568

Merged
merged 4 commits into from
Jul 14, 2024
Merged

Conversation

HJ-Young
Copy link
Contributor

@HJ-Young HJ-Young commented Jul 2, 2024

Purpose of the PR

  • close #xxx

Main Changes

Verifying these changes

  • Trivial rework / code cleanup without any test coverage. (No Need)
  • Already covered by existing tests, such as AuthTest.
  • Need tests and can be verified as follows:
    • xxx

Does this PR potentially affect the following parts?

Documentation Status

  • Doc - TODO
  • Doc - Done
  • Doc - No Need

@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Jul 2, 2024
@HJ-Young HJ-Young changed the title fix(server): Random generate default jwt secret key fix(server): random generate default jwt secret key Jul 2, 2024
@imbajin imbajin requested review from javeme and imbajin July 5, 2024 11:21
@imbajin imbajin added this to the 1.5.0 milestone Jul 5, 2024
@HJ-Young HJ-Young changed the title fix(server): random generate default jwt secret key fix(server): random generate default value Jul 5, 2024
Copy link
Member

@imbajin imbajin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution~

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jul 13, 2024
Copy link

codecov bot commented Jul 13, 2024

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.

Project coverage is 4.56%. Comparing base (37e71c4) to head (85c2b6d).
Report is 2 commits behind head on master.

Files Patch % Lines
.../java/org/apache/hugegraph/config/AuthOptions.java 0.00% 5 Missing ⚠️
...org/apache/hugegraph/auth/StandardAuthManager.java 0.00% 1 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (37e71c4) and HEAD (85c2b6d). Click for more details.

HEAD has 5 uploads less than BASE
Flag BASE (37e71c4) HEAD (85c2b6d)
6 1
Additional details and impacted files
@@             Coverage Diff              @@
##             master   #2568       +/-   ##
============================================
- Coverage     56.42%   4.56%   -51.87%     
+ Complexity      586     479      -107     
============================================
  Files           612     621        +9     
  Lines         49672   50875     +1203     
  Branches       6681    6570      -111     
============================================
- Hits          28029    2321    -25708     
- Misses        18833   48367    +29534     
+ Partials       2810     187     -2623     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@VGalaxies VGalaxies merged commit 03b40a5 into apache:master Jul 14, 2024
13 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants