Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: reset license header for file declared in LICENSE #2550

Merged
merged 1 commit into from
Jun 11, 2024

Conversation

VGalaxies
Copy link
Contributor

I notice that https://github.com/apache/incubator-hugegraph/blob/master/LICENSE#L210, the license header of StructureBasicSuite.java should be the same as ProcessBasicSuite.java?

@VGalaxies VGalaxies requested a review from imbajin June 4, 2024 14:01
@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Jun 4, 2024
@VGalaxies VGalaxies self-assigned this Jun 4, 2024
@VGalaxies
Copy link
Contributor Author

@msgui could take a look here~

Copy link

codecov bot commented Jun 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.00%. Comparing base (b056c5f) to head (76fc015).

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #2550      +/-   ##
============================================
+ Coverage     56.95%   57.00%   +0.04%     
- Complexity      827      829       +2     
============================================
  Files           612      612              
  Lines         49652    49652              
  Branches       6675     6675              
============================================
+ Hits          28279    28302      +23     
+ Misses        18558    18542      -16     
+ Partials       2815     2808       -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@imbajin imbajin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, maybe we need also search some keyword like @author * or mail format to check the source code reference

@imbajin imbajin added this to the 1.5.0 milestone Jun 5, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jun 5, 2024
@VGalaxies
Copy link
Contributor Author

Yes, maybe we need also search some keyword like @author * or mail format to check the source code reference

checked and found no omissions

@JackyYangPassion JackyYangPassion merged commit 506850c into master Jun 11, 2024
16 checks passed
@JackyYangPassion JackyYangPassion deleted the fix-license branch June 11, 2024 02:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants