Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(store): integrate store-node submodule #2537

Merged
merged 7 commits into from
Jun 10, 2024

Conversation

sheli00
Copy link
Contributor

@sheli00 sheli00 commented May 14, 2024

Subtask of #2265 and #2482

Detailed doc can be seen in this link

@dosubot dosubot bot added size:XXL This PR changes 1000+ lines, ignoring generated files. feature New feature store Store module labels May 14, 2024
@sheli00 sheli00 marked this pull request as draft May 14, 2024 11:36
@sheli00 sheli00 marked this pull request as ready for review June 8, 2024 13:58
@sheli00
Copy link
Contributor Author

sheli00 commented Jun 8, 2024

@VGalaxies @Pengzna @imbajin PTAL

@VGalaxies
Copy link
Contributor

@sheli00 could reformat the code for store-node before merging

image

@sheli00
Copy link
Contributor Author

sheli00 commented Jun 8, 2024

@sheli00 could reformat the code for store-node before merging

image

Comparing the difference between the code before and after formatting, there should be no major problems

VGalaxies
VGalaxies previously approved these changes Jun 9, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jun 9, 2024
VGalaxies
VGalaxies previously approved these changes Jun 9, 2024
Copy link

codecov bot commented Jun 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 41.30%. Comparing base (ac93dee) to head (250b83f).

Current head 250b83f differs from pull request most recent head 44fc4f8

Please upload reports for the commit 44fc4f8 to get more accurate results.

Additional details and impacted files
@@              Coverage Diff              @@
##             master    #2537       +/-   ##
=============================================
- Coverage     56.44%   41.30%   -15.14%     
+ Complexity      588      383      -205     
=============================================
  Files           612      612               
  Lines         49672    49672               
  Branches       6681     6681               
=============================================
- Hits          28035    20515     -7520     
- Misses        18826    26897     +8071     
+ Partials       2811     2260      -551     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@imbajin imbajin requested a review from VGalaxies June 10, 2024 15:48
@VGalaxies VGalaxies merged commit 1a89595 into apache:master Jun 10, 2024
14 checks passed
@VGalaxies VGalaxies changed the title feat(store): integrate store-node submodule feat(store): integrate store-node submodule Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature lgtm This PR has been approved by a maintainer size:XXL This PR changes 1000+ lines, ignoring generated files. store Store module
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants