Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(server): serverStarted error when execute gremlin example #2473

Merged
merged 1 commit into from
Mar 5, 2024
Merged

fix(server): serverStarted error when execute gremlin example #2473

merged 1 commit into from
Mar 5, 2024

Conversation

VGalaxies
Copy link
Contributor

fix #2472

@VGalaxies VGalaxies requested a review from imbajin March 5, 2024 06:31
@VGalaxies VGalaxies self-assigned this Mar 5, 2024
@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. bug Something isn't working gremlin TinkerPop gremlin labels Mar 5, 2024
@VGalaxies VGalaxies mentioned this pull request Mar 5, 2024
Closed
1 task
@codecov Codecov
Copy link

codecov bot commented Mar 5, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.29%. Comparing base (6861ed5) to head (c47e0fa).

Additional details and impacted files 
@@             Coverage Diff              @@
##             master    #2473      +/-   ##
============================================
+ Coverage     66.23%   66.29%   +0.05%     
  Complexity      827      827              
============================================
  Files           511      511              
  Lines         42623    42623              
  Branches       5947     5947              
============================================
+ Hits          28233    28255      +22     
+ Misses        11574    11563      -11     
+ Partials       2816     2805      -11

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@imbajin imbajin requested review from javeme and liuxiaocs7 March 5, 2024 06:56
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Mar 5, 2024
liuxiaocs7
liuxiaocs7 approved these changes Mar 5, 2024
View reviewed changes
Copy link
Member

@liuxiaocs7 liuxiaocs7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@imbajin imbajin changed the title fix: serverStarted error when start gremlin-console with example.groovy fix(server): 'serverStarted' error when execute gremlin example Mar 5, 2024
@imbajin imbajin merged commit eb6570c into master Mar 5, 2024
19 of 21 checks passed
@imbajin imbajin deleted the fix-example-groovy branch March 5, 2024 07:21
@imbajin imbajin changed the title fix(server): 'serverStarted' error when execute gremlin example fix(server): serverStarted error when execute gremlin example Mar 5, 2024
VGalaxies added a commit that referenced this pull request Mar 5, 2024
@VGalaxies
fix(server): 'serverStarted' error when execute gremlin example (#2473)
bdb6476
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liuxiaocs7 liuxiaocs7 liuxiaocs7 approved these changes

@imbajin imbajin imbajin approved these changes

@javeme javeme Awaiting requested review from javeme

Assignees

@VGalaxies VGalaxies

Labels
bug Something isn't working gremlin TinkerPop gremlin lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] ./bin/gremlin-console.sh -- -i scripts/example.groovy 时一直报错
3 participants
@VGalaxies @imbajin @liuxiaocs7