Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add a newline formatting configuration and a comment for warning #2464

Merged
merged 2 commits into from
Feb 29, 2024
Merged

chore: Add a newline formatting configuration and a comment for warning #2464

merged 2 commits into from
Feb 29, 2024

Conversation

returnToInnocence
Copy link
Contributor

Purpose of the PR

Main Changes

  • Add a newline formatting configuration(via hg-style.xml)
  • Add a comment for the IDEA unsupported warning about continuation_indent_size

Verifying these changes

  • Trivial rework / code cleanup without any test coverage. (No Need)
  • Already covered by existing tests, such as (please modify tests here).
  • Need tests and can be verified as follows:
    • xxx

Does this PR potentially affect the following parts?

  • Nope
  • Dependencies (add/update license info)
  • Modify configurations
  • The public API
  • Other affects (typed here)
    • When you use hugegraph-style.xml for code reformat, this pr mentions changes that will affect the final result

Documentation Status

  • Doc - TODO
  • Doc - Done
  • Doc - No Need

@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. ci-cd Build or deploy labels Feb 28, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Feb 28, 2024
Copy link

codecov bot commented Feb 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.28%. Comparing base (47a68f0) to head (89a7708).

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #2464      +/-   ##
============================================
+ Coverage     63.80%   66.28%   +2.47%     
+ Complexity      829      827       -2     
============================================
  Files           511      511              
  Lines         42622    42622              
  Branches       5947     5947              
============================================
+ Hits          27193    28250    +1057     
+ Misses        12679    11558    -1121     
- Partials       2750     2814      +64     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@imbajin imbajin requested a review from VGalaxies February 29, 2024 11:12
@VGalaxies VGalaxies merged commit 2e3adcd into apache:master Feb 29, 2024
20 of 21 checks passed
VGalaxies pushed a commit that referenced this pull request Feb 29, 2024
…ng (#2464)

- Add a newline formatting configuration
- Add a comment for the IDEA unsupported warning about `continuation_indent_size`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-cd Build or deploy lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants