-
Notifications
You must be signed in to change notification settings - Fork 521
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BREAKING CHANGE(server): unify to call SchemaLabel.getLabelId() #2458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change-Id: I31bcc0d1ee99f3c443f8f4f0d458e06ca89977ef
dosubot
bot
added
size:M
This PR changes 30-99 lines, ignoring generated files.
api
Changes of API
labels
Feb 24, 2024
imbajin
approved these changes
Feb 24, 2024
zyxxoo
approved these changes
Feb 24, 2024
VGalaxies
pushed a commit
that referenced
this pull request
Feb 25, 2024
Change-Id: I31bcc0d1ee99f3c443f8f4f0d458e06ca89977ef
imbajin
reviewed
Apr 15, 2024
Comment on lines
+55
to
+58
E.checkArgument(this.label == null, | ||
"Just provide one of ids or label of source vertices"); | ||
E.checkArgument(props == null || props.isEmpty(), | ||
"Just provide one of ids or properties of source vertices"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NOTE: it's a BREAKING CHANGE
, we need change the PR title to BREAKING CHANGE: xxx
in the future & alert the users/devs to check it
related CI error when upgrade the server: https://github.com/apache/incubator-hugegraph-ai/actions/runs/8673001982/job/23783894307
imbajin
changed the title
chore: unify to call SchemaLabel.getLabelId()
BREAKING CHANGE: unify to call SchemaLabel.getLabelId()
Apr 15, 2024
imbajin
changed the title
BREAKING CHANGE: unify to call SchemaLabel.getLabelId()
BREAKING CHANGE(server): unify to call SchemaLabel.getLabelId()
Apr 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change-Id: I31bcc0d1ee99f3c443f8f4f0d458e06ca89977ef