Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BREAKING CHANGE(server): unify to call SchemaLabel.getLabelId() #2458

Merged
merged 1 commit into from
Feb 24, 2024

Conversation

javeme
Copy link
Contributor

@javeme javeme commented Feb 24, 2024

Change-Id: I31bcc0d1ee99f3c443f8f4f0d458e06ca89977ef

Change-Id: I31bcc0d1ee99f3c443f8f4f0d458e06ca89977ef
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. api Changes of API labels Feb 24, 2024
Copy link

codecov bot commented Feb 24, 2024

Codecov Report

Attention: Patch coverage is 53.84615% with 12 lines in your changes are missing coverage. Please review.

Project coverage is 66.29%. Comparing base (bc421bb) to head (0e4a123).

Files Patch % Lines
.../org/apache/hugegraph/api/traversers/Vertices.java 33.33% 0 Missing and 2 partials ⚠️
...aph/traversal/algorithm/ShortestPathTraverser.java 0.00% 2 Missing ⚠️
...che/hugegraph/job/algorithm/AbstractAlgorithm.java 0.00% 1 Missing ⚠️
...gorithm/cent/BetweennessCentralityAlgorithmV2.java 0.00% 1 Missing ⚠️
...algorithm/cent/ClosenessCentralityAlgorithmV2.java 0.00% 1 Missing ⚠️
.../job/algorithm/cent/DegreeCentralityAlgorithm.java 0.00% 1 Missing ⚠️
...ob/algorithm/cent/StressCentralityAlgorithmV2.java 0.00% 1 Missing ⚠️
...che/hugegraph/job/algorithm/comm/LpaAlgorithm.java 0.00% 1 Missing ⚠️
...e/hugegraph/traversal/algorithm/HugeTraverser.java 50.00% 1 Missing ⚠️
...aph/traversal/algorithm/SameNeighborTraverser.java 50.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #2458      +/-   ##
============================================
+ Coverage     66.23%   66.29%   +0.05%     
  Complexity      827      827              
============================================
  Files           511      511              
  Lines         42582    42580       -2     
  Branches       5935     5934       -1     
============================================
+ Hits          28204    28228      +24     
+ Misses        11566    11550      -16     
+ Partials       2812     2802      -10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Feb 24, 2024
@imbajin imbajin requested a review from VGalaxies February 24, 2024 11:24
@javeme javeme merged commit eef3b35 into master Feb 24, 2024
20 of 21 checks passed
@javeme javeme deleted the unify-get-label-id branch February 24, 2024 14:45
VGalaxies pushed a commit that referenced this pull request Feb 25, 2024
Change-Id: I31bcc0d1ee99f3c443f8f4f0d458e06ca89977ef
Comment on lines +55 to +58
E.checkArgument(this.label == null,
"Just provide one of ids or label of source vertices");
E.checkArgument(props == null || props.isEmpty(),
"Just provide one of ids or properties of source vertices");
Copy link
Member

@imbajin imbajin Apr 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NOTE: it's a BREAKING CHANGE, we need change the PR title to BREAKING CHANGE: xxx in the future & alert the users/devs to check it

related CI error when upgrade the server: https://github.com/apache/incubator-hugegraph-ai/actions/runs/8673001982/job/23783894307

@imbajin imbajin changed the title chore: unify to call SchemaLabel.getLabelId() BREAKING CHANGE: unify to call SchemaLabel.getLabelId() Apr 15, 2024
@imbajin imbajin changed the title BREAKING CHANGE: unify to call SchemaLabel.getLabelId() BREAKING CHANGE(server): unify to call SchemaLabel.getLabelId() Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Changes of API lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants