Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pd-store): correct license in hugegraph-store #2447

Merged
merged 3 commits into from
Feb 20, 2024

Conversation

VGalaxies
Copy link
Contributor

@VGalaxies VGalaxies commented Feb 6, 2024

subtask of #2265

follow up #2435 on pd-store branch

NOTE: this PR removed some meaningless configuration files

hugegraph-store/build-change.sh
hugegraph-store/build-pre.sh
hugegraph-store/build.sh
hugegraph-store/ci.yml
hugegraph-store/deploy-release.sh
hugegraph-store/deploy-snapshot.sh
hugegraph-store/hg-store-cli/deploy-snapshot.sh
hugegraph-store/hg-store-client/deploy-snapshot.sh
hugegraph-store/hg-store-common/mvnw
hugegraph-store/hg-store-common/mvnw.cmd
hugegraph-store/hg-store-core/build.sh
hugegraph-store/hg-store-grpc/build.sh
hugegraph-store/hg-store-node/src/assembly/static/bin/app.sh
hugegraph-store/hg-store-node/src/assembly/static/bin/hg-get-release.sh
hugegraph-store/hg-store-node/src/assembly/static/bin/hg-update.sh
hugegraph-store/init.sh
hugegraph-store/local-release.sh
hugegraph-store/run.sh
hugegraph-store/settings.xml

marked them for future need

@VGalaxies VGalaxies added the store Store module label Feb 6, 2024
@VGalaxies VGalaxies requested a review from imbajin February 6, 2024 13:56
@VGalaxies VGalaxies self-assigned this Feb 6, 2024
@dosubot dosubot bot added size:XL This PR changes 500-999 lines, ignoring generated files. ci-cd Build or deploy labels Feb 6, 2024
@VGalaxies
Copy link
Contributor Author

VGalaxies commented Feb 6, 2024

@Pengzna could also help check it by following the guide from Project Migration/Package Name Change + IDEA Configuration Instructions (Complete Version)~

Copy link

codecov bot commented Feb 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (pd-store@7b14857). Click here to learn what that means.

Additional details and impacted files
@@             Coverage Diff             @@
##             pd-store    #2447   +/-   ##
===========================================
  Coverage            ?   55.27%           
  Complexity          ?     1901           
===========================================
  Files               ?      718           
  Lines               ?    58293           
  Branches            ?     7483           
===========================================
  Hits                ?    32219           
  Misses              ?    22903           
  Partials            ?     3171           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@imbajin imbajin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

checked almost all files, better to mark deleted files(PR link) in a separate doc

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Feb 7, 2024
@imbajin imbajin merged commit e4bd644 into pd-store Feb 20, 2024
16 of 17 checks passed
@imbajin imbajin deleted the store-license-header branch February 20, 2024 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-cd Build or deploy lgtm This PR has been approved by a maintainer size:XL This PR changes 500-999 lines, ignoring generated files. store Store module
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants