Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: format and clean code in core module #2440

Merged
merged 4 commits into from
Feb 20, 2024
Merged

Conversation

msgui
Copy link
Contributor

@msgui msgui commented Feb 2, 2024

Purpose of the PR

Main Changes

Format & clean code in submodels:

  1. Core

Verifying these changes

  • Trivial rework / code cleanup without any test coverage. (No Need)
  • Already covered by existing tests, such as (please modify tests here).
  • Need tests and can be verified as follows:
    • xxx

Does this PR potentially affect the following parts?

  • Nope
  • Dependencies (add/update license info)
  • Modify configurations
  • The public API
  • Other affects (typed here)

Documentation Status

  • Doc - TODO
  • Doc - Done
  • Doc - No Need

@dosubot dosubot bot added size:XL This PR changes 500-999 lines, ignoring generated files. ci-cd Build or deploy labels Feb 2, 2024
@msgui msgui changed the title chore: Format&Clean code 2 fix: Format and clean code in server module Feb 2, 2024
@dosubot dosubot bot modified the milestones: 1.3.0, 1.5.0 Feb 2, 2024
@msgui msgui changed the title fix: Format and clean code in server module fix: fformat and clean code in server module Feb 2, 2024
@msgui msgui changed the title fix: fformat and clean code in server module fix: format and clean code in server module Feb 2, 2024
@msgui msgui marked this pull request as draft February 3, 2024 02:43
@msgui msgui changed the title fix: format and clean code in server module fix: format and clean code in server module[wip] Feb 3, 2024
Copy link

codecov bot commented Feb 3, 2024

Codecov Report

Attention: 124 lines in your changes are missing coverage. Please review.

Comparison is base (7586779) 66.21% compared to head (3061943) 66.21%.

Files Patch % Lines
...ache/hugegraph/backend/store/raft/RaftContext.java 0.00% 10 Missing ⚠️
...hugegraph/util/collection/IntMapByDynamicHash.java 53.84% 6 Missing ⚠️
...raph/job/algorithm/cent/AbstractCentAlgorithm.java 0.00% 5 Missing ⚠️
...g/apache/hugegraph/task/StandardTaskScheduler.java 44.44% 3 Missing and 2 partials ⚠️
.../org/apache/hugegraph/variables/HugeVariables.java 0.00% 5 Missing ⚠️
.../store/raft/compress/ParallelCompressStrategy.java 0.00% 4 Missing ⚠️
...he/hugegraph/backend/tx/GraphIndexTransaction.java 80.00% 4 Missing ⚠️
...hugegraph/job/algorithm/comm/LouvainTraverser.java 0.00% 4 Missing ⚠️
...pache/hugegraph/job/computer/AbstractComputer.java 0.00% 4 Missing ⚠️
...apache/hugegraph/security/HugeSecurityManager.java 33.33% 1 Missing and 3 partials ⚠️
... and 48 more
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #2440      +/-   ##
============================================
- Coverage     66.21%   66.21%   -0.01%     
  Complexity      828      828              
============================================
  Files           511      511              
  Lines         42598    42590       -8     
  Branches       5942     5939       -3     
============================================
- Hits          28208    28199       -9     
+ Misses        11582    11578       -4     
- Partials       2808     2813       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@msgui msgui changed the title fix: format and clean code in server module[wip] fix: format and clean code in server module Feb 3, 2024
@msgui msgui marked this pull request as ready for review February 3, 2024 03:50
@dosubot dosubot bot added the bug Something isn't working label Feb 3, 2024
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. and removed size:XL This PR changes 500-999 lines, ignoring generated files. labels Feb 7, 2024
@msgui msgui changed the title fix: format and clean code in server module fix: format and clean code in core module Feb 8, 2024
@msgui msgui marked this pull request as draft February 8, 2024 16:27
@msgui msgui marked this pull request as ready for review February 19, 2024 04:46
@dosubot dosubot bot added the feature New feature label Feb 19, 2024
Comment on lines -124 to +128
StandardHugeGraph.class,
StandardHugeGraph.StandardHugeGraphParams.class,
TinkerPopTransaction.class,
StandardHugeGraph.Txs.class,
StandardHugeGraph.SysTransaction.class
StandardHugeGraph.class,
StandardHugeGraph.StandardHugeGraphParams.class,
TinkerPopTransaction.class,
StandardHugeGraph.Txs.class,
StandardHugeGraph.SysTransaction.class
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMPORTANT: we need to ensure 4 or 8 spaces to format (and sync to "hugegraph-style" config files & other PRs)

Copy link
Member

@imbajin imbajin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check Most of the files have been checked

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Feb 19, 2024
@imbajin imbajin requested a review from VGalaxies February 19, 2024 12:25
@imbajin imbajin merged commit 0b70e89 into apache:master Feb 20, 2024
19 of 23 checks passed
@msgui msgui deleted the format-2 branch March 15, 2024 04:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ci-cd Build or deploy feature New feature lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants