Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(server): change the arthas bind ip #2429

Closed
wants to merge 9 commits into from
Closed

fix(server): change the arthas bind ip #2429

Show file tree
Hide file tree
Changes from 8 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
ae90955
chore(server): update swagger info for default server profile
SunnyBoy-WYH Jan 19, 2024
bb67693
chore(server): update swagger info for default server profile
SunnyBoy-WYH Jan 19, 2024
13f916f
fix(server): arthas default bind ip should not be 0.0.0.0
SunnyBoy-WYH Jan 27, 2024
30f1821
Merge branch 'master' into arthas-bind-ip
SunnyBoy-WYH Jan 27, 2024
2519b39
fix(server): arthas default bind ip should not be 0.0.0.0
SunnyBoy-WYH Jan 27, 2024
c787baf
Merge branch 'master' into arthas-bind-ip
SunnyBoy-WYH Feb 21, 2024
7d75e0d
fix(server): fix the bug which promtheus cant collect hg metric
SunnyBoy-WYH Feb 21, 2024
552dcb8
fix(server): fix the arthas default bind ip to 127.0.0.1
SunnyBoy-WYH Feb 27, 2024
fae15ca
Merge branch 'master' into arthas-bind-ip
SunnyBoy-WYH Jun 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion hugegraph-server/hugegraph-api/src/main/java/org/apache/hugegraph/config/ServerOptions.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -294,7 +294,7 @@ public static synchronized ServerOptions instance() {
"arthas.ip",
"The IP provided by Arthas, it can be accessible from the outside.",
disallowEmpty(),
"0.0.0.0"
"127.0.0.1"
Copy link
Member

@imbajin imbajin Feb 28, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any context for it (change the IP to localhost)?

Copy link
Contributor Author

@SunnyBoy-WYH SunnyBoy-WYH Feb 28, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the context you can see the introduction about this issue. i think 0.0.0.0 means any ip, and arthas will set default password, sometime the ci failed.

why prefer localhost not 127.0.0.1? the config item provided by arthas named 'arthas.ip',im not sure localhost as a domain will work.

);

public static final ConfigOption<String> ARTHAS_DISABLED_COMMANDS =
Expand Down
2 changes: 1 addition & 1 deletion hugegraph-server/hugegraph-dist/src/assembly/static/conf/rest-server.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ batch.max_write_threads=0
# configuration of arthas
arthas.telnet_port=8562
arthas.http_port=8561
arthas.ip=0.0.0.0
arthas.ip=127.0.0.1
arthas.disabled_commands=jad

# authentication configs
Expand Down
7 changes: 0 additions & 7 deletions hugegraph-server/hugegraph-test/src/main/java/org/apache/hugegraph/api/ArthasApiTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,16 +43,9 @@ public void testArthasApi() {
" \"command\": \"version\"\n" +
"}";
RestClient arthasApiClient = new RestClient(ARTHAS_API_BASE_URL, false);
// If the request header contains basic auth,
// and if we are not set auth when arthas attach hg, arthas will auth it and return 401.
// ref:https://arthas.aliyun.com/en/doc/auth.html#configure-username-and-password
Response r = arthasApiClient.post(ARTHAS_API_PATH, body);
String result = assertResponseStatus(200, r);
assertJsonContains(result, "state");
assertJsonContains(result, "body");

RestClient arthasApiClientWithAuth = new RestClient(ARTHAS_API_BASE_URL);
r = arthasApiClientWithAuth.post(ARTHAS_API_PATH, body);
assertResponseStatus(401, r);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we add some exception cases for invalid requests

Copy link
Contributor Author

@SunnyBoy-WYH SunnyBoy-WYH Mar 10, 2024 •
edited by imbajin
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes we will do later

}
}
Loading