fix(auth): enhance the URL check #2422
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
size:S
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2422 +/- ##
============================================
+ Coverage 66.26% 66.31% +0.04%
Complexity 827 827
============================================
Files 511 511
Lines 42623 42624 +1
Branches 5947 5947
============================================
+ Hits 28245 28264 +19
+ Misses 11563 11553 -10
+ Partials 2815 2807 -8 ☔ View full report in Codecov by Sentry. |
imbajin
changed the title
imbajin
reviewed
Jan 19, 2024
| for (String whiteApi : WHITE_API_LIST) { | ||
| if (path.endsWith(whiteApi)) { | ||
| if (MATCHER.match(whiteApi, path)) { |
imbajin
changed the title
|
seems this pr will also solve #2176 |
javeme
previously approved these changes
Mar 3, 2024
dosubot
bot
added
size:M
imbajin
previously approved these changes
Mar 8, 2024
imbajin
approved these changes
Mar 8, 2024
| @@ -51,11 +51,12 @@ For example: | |||
|
|
|||
| <!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. --> | |||
|
|
|||
| - [ ] Nope | |||
| - [ ] Dependencies (add/update license info) <!-- Don't forget to add/update the info in "LICENSE" & "NOTICE" files (both in root & dist module) --> | |||
| - [ ] Dependencies ([add/update license](https://hugegraph.apache.org/docs/contribution-guidelines/contribute/#321-check-licenses) info & [regenerate_dependencies](../hugegraph-server/hugegraph-dist/scripts/dependency/regenerate_known_dependencies.sh)) <!-- Don't forget to add/update the info in "LICENSE" & "NOTICE" files (both in root & dist module) --> | |||
VGalaxies
approved these changes
Mar 9, 2024
VGalaxies
pushed a commit
that referenced
this pull request
Mar 9, 2024
Co-authored-by: imbajin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.