Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(docker): cherry-pick commits from master for fix some error when using docker image for 1.2.0 as #2403 #2417

Merged
merged 1 commit into from
Jan 17, 2024

Conversation

aroundabout
Copy link
Contributor


Purpose of the PR

Main Changes

Verifying these changes

  • Trivial rework / code cleanup without any test coverage. (No Need)
  • Already covered by existing tests, such as (please modify tests here).
  • Need tests and can be verified as follows:
    • xxx

Does this PR potentially affect the following parts?

  • Nope
  • Dependencies (add/update license info)
  • Modify configurations
  • The public API
  • Other affects (typed here)

Documentation Status

  • Doc - TODO
  • Doc - Done
  • Doc - No Need

- allow user to set env for docker to set auth mode
- download keystore when package
- fix a curl error (also use curl first in `function` download)

---------

Co-authored-by: imbajin <[email protected]>
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. bug Something isn't working cassandra Cassandra backend ci-cd Build or deploy labels Jan 16, 2024
Copy link

codecov bot commented Jan 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7635c67) 65.59% compared to head (626b46d) 66.14%.

Additional details and impacted files
@@                Coverage Diff                 @@
##             docker-1.2.0    #2417      +/-   ##
==================================================
+ Coverage           65.59%   66.14%   +0.54%     
- Complexity            587      828     +241     
==================================================
  Files                 511      511              
  Lines               42590    42590              
  Branches             5941     5941              
==================================================
+ Hits                27936    28170     +234     
+ Misses              11840    11605     -235     
- Partials             2814     2815       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jan 17, 2024
@imbajin imbajin merged commit 1123e85 into apache:docker-1.2.0 Jan 17, 2024
19 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working cassandra Cassandra backend ci-cd Build or deploy lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants