fix(core): task restore interrupt problem on restart server #2401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:XS
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #2401 +/- ##
============================================
+ Coverage 65.59% 66.23% +0.64%
- Complexity 587 828 +241
============================================
Files 511 511
Lines 42590 42595 +5
Branches 5941 5942 +1
============================================
+ Hits 27936 28213 +277
+ Misses 11840 11562 -278
- Partials 2814 2820 +6 ☔ View full report in Codecov by Sentry. |
imbajin
changed the title
javeme
reviewed
Dec 25, 2023
| } | ||
| } | ||
| if (page != null) { | ||
| page = PageInfo.pageInfo(iter); | ||
| } | ||
| } while (page != null); | ||
| } | ||
| for (HugeTask<V> task : taskList){ | ||
| LOG.info("restore task {}",task ); |
| @@ -151,14 +152,18 @@ public <V> void restoreTasks() { | |||
| iter.hasNext();) { | |||
| HugeTask<V> task = iter.next(); | |||
| if (selfServer.equals(task.server())) { | |||
| this.restore(task); | |||
| taskList.add(task); | |||
There was a problem hiding this comment.
we may fix this bug by changing the order of PENDING_STATUSES elements
javeme
reviewed
Dec 28, 2023
...aph-server/hugegraph-core/src/main/java/org/apache/hugegraph/task/StandardTaskScheduler.java
Outdated
Show resolved
Hide resolved
imbajin
approved these changes
Dec 29, 2023
VGalaxies
pushed a commit
to VGalaxies/incubator-hugegraph
that referenced
this pull request
Jan 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of the PR
Main Changes
Verifying these changes
Does this PR potentially affect the following parts?
Documentation Status
Doc - TODODoc - DoneDoc - No Need