Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix EdgeExistenceAPI path #2379

Closed
wants to merge 24 commits into from
Closed

Fix EdgeExistenceAPI path #2379

wants to merge 24 commits into from

Conversation

msgui
Copy link
Contributor

@msgui msgui commented Dec 5, 2023

Purpose of the PR

Path name should match class name

Main Changes

Verifying these changes

  • Trivial rework / code cleanup without any test coverage. (No Need)
  • Already covered by existing tests, such as (please modify tests here).
  • Need tests and can be verified as follows:
    • xxx

Does this PR potentially affect the following parts?

  • Nope
  • Dependencies (add/update license info)
  • Modify configurations
  • The public API
  • Other affects (typed here)

Documentation Status

  • Doc - TODO
  • Doc - Done
  • Doc - No Need

Copy link

codecov bot commented Dec 5, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (47aa8be) 66.31% compared to head (c7d7c93) 65.82%.

❗ Current head c7d7c93 differs from pull request most recent head 644e15e. Consider uploading reports for the commit 644e15e to get more accurate results

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #2379      +/-   ##
============================================
- Coverage     66.31%   65.82%   -0.49%     
+ Complexity      830      826       -4     
============================================
  Files           510      509       -1     
  Lines         42187    42139      -48     
  Branches       5840     5836       -4     
============================================
- Hits          27977    27740     -237     
- Misses        11445    11637     +192     
+ Partials       2765     2762       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@@ -44,7 +44,7 @@
import jakarta.ws.rs.QueryParam;
import jakarta.ws.rs.core.Context;

@Path("graphs/{graph}/traversers/edgeexist")
@Path("graphs/{graph}/traversers/edgeexistence")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

prefer to rename EdgeExistence to EdgeExist

@msgui msgui closed this Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants