-
Notifications
You must be signed in to change notification settings - Fork 528
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(core): add IntMapByDynamicHash V1 implement #2377
Conversation
@imbajin PTAL |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #2377 +/- ##
============================================
- Coverage 66.31% 64.77% -1.54%
- Complexity 828 981 +153
============================================
Files 510 511 +1
Lines 42186 42643 +457
Branches 5840 5945 +105
============================================
- Hits 27975 27624 -351
- Misses 11445 12270 +825
+ Partials 2766 2749 -17 ☔ View full report in Codecov by Sentry. |
...r/hugegraph-core/src/main/java/org/apache/hugegraph/util/collection/IntMapByDynamicHash.java
Outdated
Show resolved
Hide resolved
...r/hugegraph-core/src/main/java/org/apache/hugegraph/util/collection/IntMapByDynamicHash.java
Outdated
Show resolved
Hide resolved
...r/hugegraph-core/src/main/java/org/apache/hugegraph/util/collection/IntMapByDynamicHash.java
Show resolved
Hide resolved
...r/hugegraph-core/src/main/java/org/apache/hugegraph/util/collection/IntMapByDynamicHash.java
Show resolved
Hide resolved
...r/hugegraph-core/src/main/java/org/apache/hugegraph/util/collection/IntMapByDynamicHash.java
Show resolved
Hide resolved
...r/hugegraph-core/src/main/java/org/apache/hugegraph/util/collection/IntMapByDynamicHash.java
Outdated
Show resolved
Hide resolved
...r/hugegraph-core/src/main/java/org/apache/hugegraph/util/collection/IntMapByDynamicHash.java
Outdated
Show resolved
Hide resolved
...r/hugegraph-core/src/main/java/org/apache/hugegraph/util/collection/IntMapByDynamicHash.java
Outdated
Show resolved
Hide resolved
...r/hugegraph-core/src/main/java/org/apache/hugegraph/util/collection/IntMapByDynamicHash.java
Outdated
Show resolved
Hide resolved
} | ||
} | ||
|
||
private static class Entry { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
expect to serialize it into a chunk memory
From line L735 ~ L972, some suggestions from Copilot:
Please note that these are potential issues that could lead to bugs based on the provided code snippet. Whether they could actually pose problems depends on the exact workflow and environment in which this code is used. It would also benefit from unit-tests to assure that functionality is as expected. |
...aph-test/src/test/java/org/apache/hugegraph/benchmark/map/MapRandomGetPutThroughputTest.java
Outdated
Show resolved
Hide resolved
...aph-test/src/test/java/org/apache/hugegraph/benchmark/map/MapRandomGetPutThroughputTest.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We merge this V1 version first for release 1.2.0, and link it to the summary issue (enhance it in the future)
* feat(WIP): add IntMapByDynamicHash (apache#2294) * feat: add values & keys in IntMapByDynamicHash * add some basic comment & fix some style * feat: fix pr review * fix: fix some review --------- Co-authored-by: imbajin <[email protected]>
Purpose of the PR
Add IntMapByDynamicHash for high performance, lockless, concurrency secure hashmap.
Main Changes
Verifying these changes
Dynamic Capcitity
With Init Capcitity
Does this PR potentially affect the following parts?
Documentation Status
Doc - TODO
Doc - Done
Doc - No Need