Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: rollback cassandra to 3.11.16 #2374

Closed
wants to merge 6 commits into from
Closed

chore: rollback cassandra to 3.11.16 #2374

wants to merge 6 commits into from

Conversation

Zony7
Copy link
Contributor

@Zony7 Zony7 commented Dec 4, 2023

Purpose of the PR

This pull request reverts the changes introduced in PR #2300 , which upgraded Cassandra from version 3.11.12 to 4.0.10. The upgrade caused compatibility issues that were not anticipated, and as a result, we are reverting back to 3.11.16 version to maintain stability and functionality.

Main Changes

  • Reverting the Cassandra version from 4.0.10 to 3.11.16 to address compatibility issues.
  • Ensuring stability and functionality are maintained during this transition.

Note Regarding 3rd Party Error

Users experiencing the error reported by 3rd party (GHSA-m9p2-j4hg-g373) should note that we have upgraded to Cassandra version 3.11.16.

image

This issue may be related to Cassandra 3, and any resolution might be addressed when upgrading to Cassandra 4. As this is not within our control, we recommend monitoring Cassandra updates for a potential fix.

屏幕截图 2023-12-04 214128

Verifying these changes

  • Trivial rework / code cleanup without any test coverage. (No Need)
  • Already covered by existing tests, such as (please modify tests here).
  • Need tests and can be verified as follows:
    • xxx

Does this PR potentially affect the following parts?

  • Nope
  • Dependencies (add/update license info)
  • Modify configurations
  • The public API
  • Other affects (typed here)

Documentation Status

  • Doc - TODO
  • Doc - Done
  • Doc - No Need

Copy link

codecov bot commented Dec 4, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (20d1e52) 53.81% compared to head (07c3d8c) 66.26%.
Report is 10 commits behind head on master.

Additional details and impacted files
@@              Coverage Diff              @@
##             master    #2374       +/-   ##
=============================================
+ Coverage     53.81%   66.26%   +12.44%     
- Complexity      545      830      +285     
=============================================
  Files           509      509               
  Lines         42139    42139               
  Branches       5836     5836               
=============================================
+ Hits          22679    27922     +5243     
+ Misses        17027    11459     -5568     
- Partials       2433     2758      +325     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Zony7 Zony7 changed the title chore: rollback cassandra to 3.11.12 chore: rollback cassandra to 3.11.16 Dec 4, 2023
@aroundabout
Copy link
Contributor

aroundabout commented Dec 4, 2023

There is a related file here, we use cassandra:4 in docker-compose. If we rollback cassandra, maybe we should change the version here.
I think we only need to change it to cassandra:3.11.

@imbajin
Copy link
Member

imbajin commented Dec 4, 2023

There is a related file here, we use cassandra:4 in docker-compose. If we rollback cassandra, maybe we should change the version here.
I think we only need to change it to cassandra:3.11.

thanks for the reminder,seems we do need it

@Zony7
Copy link
Contributor Author

Zony7 commented Dec 4, 2023

There is a related file here, we use cassandra:4 in docker-compose. If we rollback cassandra, maybe we should change the version here. I think we only need to change it to cassandra:3.11.

thank you! I will fix it

Copy link
Member

@imbajin imbajin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wait u to ensure the #2365 CI passed

Update in 12.6: Suspend this PR due to #2365 CI passed (we need dig out the reason maybe?)

@imbajin imbajin marked this pull request as draft December 6, 2023 09:42
@Zony7 Zony7 closed this Dec 18, 2023
@Zony7 Zony7 reopened this Dec 18, 2023
@Zony7 Zony7 closed this Dec 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants