Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: move server info into GlobalMasterInfo #2370

Merged
merged 4 commits into from
Dec 4, 2023
Merged

Conversation

javeme
Copy link
Contributor

@javeme javeme commented Dec 2, 2023

Change-Id: Id854892333115fd45d7c8b9799d255627541b2ad

Copy link

codecov bot commented Dec 2, 2023

Codecov Report

Attention: 57 lines in your changes are missing coverage. Please review.

Comparison is base (ed493f3) 66.26% compared to head (cb27fb5) 65.85%.

Files Patch % Lines
...a/org/apache/hugegraph/task/ServerInfoManager.java 65.95% 5 Missing and 11 partials ⚠️
...hugegraph/masterelection/StandardRoleListener.java 47.61% 10 Missing and 1 partial ⚠️
...n/java/org/apache/hugegraph/core/GraphManager.java 66.66% 4 Missing and 5 partials ⚠️
...che/hugegraph/masterelection/GlobalMasterInfo.java 81.25% 3 Missing and 3 partials ⚠️
...rg/apache/hugegraph/api/filter/RedirectFilter.java 33.33% 2 Missing and 2 partials ⚠️
...g/apache/hugegraph/task/StandardTaskScheduler.java 60.00% 0 Missing and 4 partials ⚠️
...sterelection/StandardRoleElectionStateMachine.java 76.92% 1 Missing and 2 partials ⚠️
...in/java/org/apache/hugegraph/task/TaskManager.java 83.33% 1 Missing and 1 partial ⚠️
.../org/apache/hugegraph/auth/HugeGraphAuthProxy.java 50.00% 1 Missing ⚠️
...n/java/org/apache/hugegraph/StandardHugeGraph.java 93.75% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #2370      +/-   ##
============================================
- Coverage     66.26%   65.85%   -0.42%     
+ Complexity      830      826       -4     
============================================
  Files           509      509              
  Lines         42106    42139      +33     
  Branches       5833     5836       +3     
============================================
- Hits          27903    27751     -152     
- Misses        11450    11625     +175     
- Partials       2753     2763      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Change-Id: Id854892333115fd45d7c8b9799d255627541b2ad
Change-Id: Ic2878c5359e7f55fcd11986aa0bf79241c7ee9ab
@javeme javeme force-pushed the server-info-to-global branch 2 times, most recently from 454eb89 to cd05642 Compare December 3, 2023 09:12
Change-Id: I6932893c4be8331547f3b721083ca00430f85e58
Change-Id: I7b3e8e2867dcf1063a726c8005f1c34dbd218f7c
@javeme javeme force-pushed the server-info-to-global branch from cd05642 to cb27fb5 Compare December 3, 2023 13:11
@javeme javeme requested review from zyxxoo, z7658329 and imbajin December 3, 2023 13:17
Copy link
Member

@imbajin imbajin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cassandra CI failed due to com.datastax.xxx not compatible with C* 4 now, consider revert or refactor it soon

@simon824 simon824 merged commit 20d1e52 into master Dec 4, 2023
17 of 21 checks passed
@simon824 simon824 deleted the server-info-to-global branch December 4, 2023 04:43
VGalaxies pushed a commit to VGalaxies/incubator-hugegraph that referenced this pull request Jan 12, 2024
* chore: move server info into GlobalMasterInfo

Change-Id: Id854892333115fd45d7c8b9799d255627541b2ad

* fix testClearAndInit() and export GlobalMasterInfo

Change-Id: Ic2878c5359e7f55fcd11986aa0bf79241c7ee9ab

* enhence ServerInfoManager.heartbeat()

Change-Id: I6932893c4be8331547f3b721083ca00430f85e58

* move RoleElectionStateMachineTest to UnitTestSuite

Change-Id: I7b3e8e2867dcf1063a726c8005f1c34dbd218f7c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants