Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): handle schema Cache expandCapacity concurrent problem #2332

Merged
merged 1 commit into from
Oct 25, 2023

Conversation

conghuhu
Copy link
Contributor

@conghuhu conghuhu commented Oct 22, 2023

Purpose of the PR

fix #2330

Main Changes

Verifying these changes

  • Trivial rework / code cleanup without any test coverage. (No Need)
  • Already covered by existing tests, such as (please modify tests here).
  • Need tests and can be verified as follows:
    • org.apache.hugegraph.unit.store.RamIntObjectMapTest

before:
59cc5898-3932-4d58-9c71-e5e00f598507

after:
Uploading image.png…

Does this PR potentially affect the following parts?

  • Nope
  • Dependencies (add/update license info)
  • Modify configurations
  • The public API
  • Other affects (typed here)

Documentation Status

  • Doc - TODO
  • Doc - Done
  • Doc - No Need

@conghuhu
Copy link
Contributor Author

@imbajin PTAL

@codecov
Copy link

codecov bot commented Oct 22, 2023

Codecov Report

Merging #2332 (a28e6dd) into master (869fc81) will increase coverage by 1.07%.
Report is 2 commits behind head on master.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master    #2332      +/-   ##
============================================
+ Coverage     63.85%   64.93%   +1.07%     
- Complexity      684      686       +2     
============================================
  Files           505      505              
  Lines         41902    41903       +1     
  Branches       5817     5817              
============================================
+ Hits          26756    27209     +453     
+ Misses        12455    11997     -458     
- Partials       2691     2697       +6     
Files Coverage Δ
...ache/hugegraph/backend/store/ram/IntObjectMap.java 73.07% <100.00%> (+1.07%) ⬆️

... and 28 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@imbajin imbajin requested a review from javeme October 23, 2023 08:33
@imbajin imbajin changed the title fix: fix 2330 & Schema Cache expandCapacity concurrent issue fix(core): handle schema Cache expandCapacity concurrent problem Oct 23, 2023
Copy link
Contributor

@javeme javeme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@imbajin imbajin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@imbajin imbajin merged commit e90489f into apache:master Oct 25, 2023
17 of 21 checks passed
@conghuhu conghuhu deleted the fix-concurrent branch October 26, 2023 11:45
VGalaxies pushed a commit to VGalaxies/incubator-hugegraph that referenced this pull request Nov 10, 2023
@imbajin
Copy link
Member

imbajin commented Nov 12, 2023

Find another critical bug @conghuhu

image

maybe we don't handle all of the concurrent issues 😢

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[Bug] Schema Cache expandCapacity concurrent issue
3 participants